Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relayer tests after integration with MockChain #438

Closed
wants to merge 26 commits into from
Closed

Conversation

adizere
Copy link
Member

@adizere adizere commented Dec 3, 2020

Closes: #381


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@codecov-io
Copy link

Codecov Report

Merging #438 (5e67f50) into master (b1b37f5) will increase coverage by 25.5%.
The diff coverage is 68.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #438      +/-   ##
=========================================
+ Coverage    13.6%   39.1%   +25.5%     
=========================================
  Files          69     156      +87     
  Lines        3752   11207    +7455     
  Branches     1374    4316    +2942     
=========================================
+ Hits          513    4392    +3879     
- Misses       2618    6188    +3570     
- Partials      621     627       +6     
Impacted Files Coverage Δ
modules/src/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/events.rs 0.0% <ø> (ø)
modules/src/ics02_client/msgs.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/raw.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs 13.6% <0.0%> (-19.7%) ⬇️
modules/src/ics04_channel/error.rs 75.0% <ø> (+50.0%) ⬆️
modules/src/ics04_channel/msgs/chan_open_ack.rs 65.4% <ø> (ø)
...odules/src/ics04_channel/msgs/chan_open_confirm.rs 63.3% <ø> (ø)
modules/src/ics04_channel/msgs/chan_open_init.rs 69.5% <ø> (ø)
modules/src/ics04_channel/msgs/chan_open_try.rs 68.2% <ø> (ø)
... and 288 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be001eb...5e67f50. Read the comment docs.

@adizere adizere closed this Dec 3, 2020
@adizere adizere deleted the adi/381_pong branch December 3, 2020 16:38
@adizere
Copy link
Member Author

adizere commented Dec 3, 2020

Closing in favor of a cleaner version #440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relayer v0 tests for client update ping pong
2 participants