-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to recent stargate #449
Conversation
Codecov Report
@@ Coverage Diff @@
## master informalsystems/hermes#449 +/- ##
=========================================
+ Coverage 13.6% 29.9% +16.2%
=========================================
Files 69 156 +87
Lines 3752 12692 +8940
Branches 1374 4968 +3594
=========================================
+ Hits 513 3800 +3287
- Misses 2618 8202 +5584
- Partials 621 690 +69
Continue to review full report at Codecov.
|
…s into anca/stargate_five
…ms/ibc-rs into anca/stargate_five
…ms/ibc-rs into anca/stargate_five
…ms/ibc-rs into anca/stargate_five
For testing, based on instructions compiled by @ancazamfir, we used the config file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work, Anca!
Looks good based on our raw CLIs testing for client, connections, and channels. We'll collect follow-up stuff in 469.
* Initial migration changes * More changes, add some of the ack CLIs * cleanup * fix packet ack * clippy and fmt fixes * Fixed connOpenTry tests; ignored update client tests * Fixed ack msg tests * Added next identifier generation in mock context * Fixed ICS26 tests * Fix for relayer tests * Timeout packet, add Uninit for conn and chan, extract clientId * Fix option order in packet Tx clis * Tx result parsing (not generalized yet) * add extern paths back * WIP General event parsing out of tx response * change packet envelope to packet * Make the code compile, return clientID in relayer and CLI * event parsing and matching for conn open init * Change tm dependency, fix update client CLI * log fix and move to cosmos v0.40.0-rc5 (no changes) * Finished connection CLIs * Event parsing and fixes for channel open CLIs * add more event attributes, some refactor of the packet CLIs and packet relaying * cleanup CLI output for channel, add more fields to events * Fix relayer connection loop for dynamic IDs * Fix relayer channel loop for dynamic IDs, started on config cleanup * Cleanup relayer config * update Changelog * fix channel verification for packets * Fix changelog typo Co-authored-by: Adi Seredinschi <adi@informal.systems>
Closes: cosmos/ibc-proto-rs#12
Closes: #443
Closes: #468
Closes: #379
Description
Draft PR for migration to latest
tm
andcosmos
.Change summary:
tendermint dep
romac/skip-verif
offv0.17
added confio's ics23 crate
Height related fields
version_..
change torevision_..
@adizerecreateClient, connOpenInit, connOpenTry, chanOpenInit, chanOpenTry
do not pass an ID anymore, the allocated ID is returned in theTxResult
connection
Version
is typed (used to beString
)some raw types have changed
proto-compiler
colin/329-handshake-refactor
[X] the tonic compiler overwrites the previous prost compiler results, effect is missing files for genesis, tx, etc.[X] with temp fix for ^ the protos need some manual fixes and also the genereated files (on inculde of tendermint doesn't work)added some ack and timeout related code
For contributor use:
docs/
) and code comments.Files changed
in the Github PR explorer.