Override the light client store with the in-memory one in all commands except the relayer loop #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s except the relayer loop
ancazamfir
approved these changes
Jan 27, 2021
romac
added a commit
that referenced
this pull request
Jan 27, 2021
romac
added a commit
that referenced
this pull request
Jan 27, 2021
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…s except the relayer loop (informalsystems#562) * Formatting * Override the light client store with the in-memory one in all commands except the relayer loop * Update changelog * Cleanup
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #501
Description
Override the configured light store with the in-memory implementation in all standalone commands, thus reserving the on-disk store for the main relayer loop (
startcommand).This allows running one-off commands concurrently the main relayer loop, at the expense of performance for those commands as they will start from an empty light store every time.
This is currently good enough for v0.1.0, but be re-evaluated for v0.2.0.
This was tested by launching the relayer loop and running multiple
tx raw update-client ibc-0 ibc-1 07-tendermint-0commands concurrently.For contributor use:
docs/) and code comments.Files changedin the Github PR explorer.