Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MsgTimeoutOnClose and send it from packet-recv CLIs #564

Merged
merged 5 commits into from
Jan 28, 2021

Conversation

ancazamfir
Copy link
Collaborator

Closes: #563

Description

  • Added MsgTimeoutOnClose
  • Check destination channel state in link.rs and send MsgTimeoutOnClose to source instead of MsgRecvPacket to destination
  • Fixed parameter order in packet-recv and packet-ack
  • Updated relayer operation instructions to to use different IDs for the different chains so it is more clear which ID goes in which pozition.

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@codecov-io
Copy link

codecov-io commented Jan 28, 2021

Codecov Report

Merging #564 (3bd4fc0) into master (b1b37f5) will increase coverage by 32.2%.
The diff coverage is 67.4%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #564      +/-   ##
=========================================
+ Coverage    13.6%   45.9%   +32.2%     
=========================================
  Files          69     139      +70     
  Lines        3752    9279    +5527     
  Branches     1374       0    -1374     
=========================================
+ Hits          513    4261    +3748     
- Misses       2618    5018    +2400     
+ Partials      621       0     -621     
Impacted Files Coverage Δ
...application/ics20_fungible_token_transfer/error.rs 0.0% <0.0%> (ø)
...pplication/ics20_fungible_token_transfer/events.rs 0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs 0.0% <0.0%> (ø)
modules/src/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/error.rs 100.0% <ø> (ø)
modules/src/ics02_client/raw.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs 100.0% <ø> (+66.6%) ⬆️
modules/src/ics03_connection/msgs/conn_open_try.rs 86.7% <ø> (ø)
modules/src/ics03_connection/version.rs 97.6% <ø> (ø)
modules/src/ics04_channel/channel.rs 77.2% <ø> (+62.1%) ⬆️
... and 260 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4425648...3bd4fc0. Read the comment docs.

Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed to reproduce. Looks good, thanks Anca!

@ancazamfir ancazamfir merged commit 033af38 into master Jan 28, 2021
@ancazamfir ancazamfir deleted the anca/timeout_on_close branch January 28, 2021 11:09
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
…ems#564)

* Add MsgTimeoutOnClose, generate it from packet-recv, fix CLIs and instructions

* Update Changelog

* Clarification on how to trigger timeout on close

Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relayer should send MsgTimeoutOnClose when dest channel end is in Closed state
3 participants