Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed-up CI end-to-end tests #604

Merged
merged 14 commits into from
Feb 3, 2021
Merged

Speed-up CI end-to-end tests #604

merged 14 commits into from
Feb 3, 2021

Conversation

adizere
Copy link
Member

@adizere adizere commented Feb 3, 2021

Close: #582


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@adizere adizere changed the base branch from master to adi/gaia_v4 February 3, 2021 16:01
@adizere adizere changed the base branch from adi/gaia_v4 to master February 3, 2021 16:01
@codecov-io
Copy link

codecov-io commented Feb 3, 2021

Codecov Report

Merging #604 (81af0b0) into master (b1b37f5) will increase coverage by 31.4%.
The diff coverage is 58.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #604      +/-   ##
=========================================
+ Coverage    13.6%   45.1%   +31.4%     
=========================================
  Files          69     143      +74     
  Lines        3752    9408    +5656     
  Branches     1374       0    -1374     
=========================================
+ Hits          513    4249    +3736     
- Misses       2618    5159    +2541     
+ Partials      621       0     -621     
Impacted Files Coverage Δ
...application/ics20_fungible_token_transfer/error.rs 0.0% <0.0%> (ø)
...pplication/ics20_fungible_token_transfer/events.rs 0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs 0.0% <0.0%> (ø)
modules/src/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/error.rs 100.0% <ø> (ø)
modules/src/ics03_connection/error.rs 100.0% <ø> (+66.6%) ⬆️
modules/src/ics03_connection/events.rs 15.3% <ø> (+15.3%) ⬆️
modules/src/ics03_connection/handler.rs 100.0% <ø> (ø)
...ules/src/ics03_connection/handler/conn_open_ack.rs 95.9% <ø> (ø)
.../src/ics03_connection/handler/conn_open_confirm.rs 94.5% <ø> (ø)
... and 253 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74dcad5...81af0b0. Read the comment docs.

@adizere adizere marked this pull request as ready for review February 3, 2021 18:22
- uses: actions-rs/cargo@v1
with:
command: build
args: --workspace --all-targets
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The binary is built in debug mode (without --release). This is what accounts primarily for shortening the workflow cycle.

@@ -44,10 +44,6 @@ jobs:
with:
toolchain: stable
override: true
- uses: actions-rs/cargo@v1
with:
command: build
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This build was not necessary.

@@ -35,11 +6,11 @@ LABEL maintainer="hello@informal.systems"

ARG RELEASE

# Add jq and Python 3
RUN apt-get update -y && apt-get install python3 jq -y
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jq wasn't used in the relayer image.

.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
Co-authored-by: Romain Ruetschi <romain@informal.systems>
@andynog andynog self-requested a review February 3, 2021 18:36
Copy link
Contributor

@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of building the relayer inside the Docker container was to avoid any side effects of building in one platform but since the Docker container is Debian and the CI uses Ubuntu, I think it's all good and the speed improvement are great

@adizere
Copy link
Member Author

adizere commented Feb 3, 2021

The idea of building the relayer inside the Docker container was to avoid any side effects of building in one platform but since the Docker container is Debian and the CI uses Ubuntu, I think it's all good and the speed improvement are great

Hmm this is something I overlooked!

In a future PR, maybe we run the relayer binary directly from Github actions? This would further simplify the workflow (and probably reduce the time).

@adizere adizere merged commit bfb16d3 into master Feb 3, 2021
@adizere adizere deleted the adi/582_speedup branch February 3, 2021 18:55
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* actions dev

* Removed build step from relayer dockerfile

* Consolidated the workflows

* Debugging with Greg

* Removed debugging info

* Trying with workdir

* no neeed for --release

* One more time

* RM Redundant workdir command

* Switched back to split workflows

* Changelog

* Update .github/workflows/e2e.yaml

Co-authored-by: Romain Ruetschi <romain@informal.systems>

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up CI by re-using relayer binary for E2E tests
4 participants