-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed-up CI end-to-end tests #604
Conversation
Codecov Report
@@ Coverage Diff @@
## master #604 +/- ##
=========================================
+ Coverage 13.6% 45.1% +31.4%
=========================================
Files 69 143 +74
Lines 3752 9408 +5656
Branches 1374 0 -1374
=========================================
+ Hits 513 4249 +3736
- Misses 2618 5159 +2541
+ Partials 621 0 -621
Continue to review full report at Codecov.
|
.github/workflows/e2e.yaml
Outdated
- uses: actions-rs/cargo@v1 | ||
with: | ||
command: build | ||
args: --workspace --all-targets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The binary is built in debug mode (without --release
). This is what accounts primarily for shortening the workflow cycle.
@@ -44,10 +44,6 @@ jobs: | |||
with: | |||
toolchain: stable | |||
override: true | |||
- uses: actions-rs/cargo@v1 | |||
with: | |||
command: build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This build was not necessary.
@@ -35,11 +6,11 @@ LABEL maintainer="hello@informal.systems" | |||
|
|||
ARG RELEASE | |||
|
|||
# Add jq and Python 3 | |||
RUN apt-get update -y && apt-get install python3 jq -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jq
wasn't used in the relayer image.
Co-authored-by: Romain Ruetschi <romain@informal.systems>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea of building the relayer inside the Docker container was to avoid any side effects of building in one platform but since the Docker container is Debian and the CI uses Ubuntu, I think it's all good and the speed improvement are great
Hmm this is something I overlooked! In a future PR, maybe we run the relayer binary directly from Github actions? This would further simplify the workflow (and probably reduce the time). |
* actions dev * Removed build step from relayer dockerfile * Consolidated the workflows * Debugging with Greg * Removed debugging info * Trying with workdir * no neeed for --release * One more time * RM Redundant workdir command * Switched back to split workflows * Changelog * Update .github/workflows/e2e.yaml Co-authored-by: Romain Ruetschi <romain@informal.systems> Co-authored-by: Romain Ruetschi <romain@informal.systems>
Close: #582
For contributor use:
docs/
) and code comments.Files changed
in the Github PR explorer.