Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change types, traits, enums names to CamelCase #690

Merged
merged 2 commits into from
Feb 19, 2021
Merged

Conversation

ancazamfir
Copy link
Collaborator

Closes: #689

Description

No functional changes, simply renaming some types and enums to follow Rust guidelines.


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@ancazamfir ancazamfir requested a review from romac as a code owner February 19, 2021 14:54
@codecov-io
Copy link

Codecov Report

Merging #690 (e2e4310) into master (b1b37f5) will increase coverage by 31.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #690      +/-   ##
=========================================
+ Coverage    13.6%   45.0%   +31.3%     
=========================================
  Files          69     150      +81     
  Lines        3752    9905    +6153     
  Branches     1374       0    -1374     
=========================================
+ Hits          513    4459    +3946     
- Misses       2618    5446    +2828     
+ Partials      621       0     -621     
Impacted Files Coverage Δ
modules/src/address.rs 100.0% <ø> (ø)
...application/ics20_fungible_token_transfer/error.rs 0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs 0.0% <ø> (ø)
modules/src/events.rs 0.0% <ø> (ø)
modules/src/handler.rs 100.0% <ø> (ø)
modules/src/ics02_client/client_def.rs 48.3% <ø> (ø)
modules/src/ics02_client/client_type.rs 79.1% <ø> (+31.5%) ⬆️
modules/src/ics02_client/context.rs 100.0% <ø> (ø)
modules/src/ics02_client/error.rs 100.0% <ø> (ø)
modules/src/ics02_client/events.rs 15.7% <ø> (+15.7%) ⬆️
... and 255 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae36bba...e2e4310. Read the comment docs.

@ancazamfir ancazamfir merged commit e7e76d3 into master Feb 19, 2021
@ancazamfir ancazamfir deleted the anca/camelcase branch February 19, 2021 17:47
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CamelCase for types, traits and enum variants
3 participants