Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBT: check that clients and connections match those in the model #704

Closed
wants to merge 131 commits into from

Conversation

vitorenesduarte
Copy link
Contributor

@vitorenesduarte vitorenesduarte commented Feb 23, 2021

Closes: #629

Description


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@vitorenesduarte vitorenesduarte changed the title MBT: check that clients and connections match the those in the model MBT: check that clients and connections match those in the model Feb 23, 2021
@vitorenesduarte vitorenesduarte changed the base branch from master to vitor/mbt_ics03 March 1, 2021 08:16
@vitorenesduarte vitorenesduarte changed the base branch from vitor/mbt_ics03 to master March 2, 2021 11:10
@codecov-io
Copy link

Codecov Report

Merging #704 (2025a9c) into master (b1b37f5) will increase coverage by 30.6%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #704      +/-   ##
=========================================
+ Coverage    13.6%   44.3%   +30.6%     
=========================================
  Files          69     152      +83     
  Lines        3752   10052    +6300     
  Branches     1374       0    -1374     
=========================================
+ Hits          513    4458    +3945     
- Misses       2618    5594    +2976     
+ Partials      621       0     -621     
Impacted Files Coverage Δ
modules/src/address.rs 100.0% <ø> (ø)
...application/ics20_fungible_token_transfer/error.rs 0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs 0.0% <ø> (ø)
modules/src/events.rs 0.0% <ø> (ø)
modules/src/handler.rs 100.0% <ø> (ø)
modules/src/ics02_client/client_def.rs 47.7% <ø> (ø)
modules/src/ics02_client/client_type.rs 79.1% <ø> (+31.5%) ⬆️
modules/src/ics02_client/context.rs 100.0% <ø> (ø)
modules/src/ics02_client/error.rs 100.0% <ø> (ø)
modules/src/ics02_client/events.rs 15.7% <ø> (+15.7%) ⬆️
... and 255 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51386f9...b1decfb. Read the comment docs.

@vitorenesduarte vitorenesduarte deleted the vitor/629 branch March 8, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MBT: check that the chain state (height, clients, connections, ...) matches the one in the model
2 participants