Fix ibc-proto recompilation bug #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
approved these changes
Apr 7, 2021
|
Pushed a couple commits to fix an issue with the Git clone and a typo, looks good otherwise :) |
romac
added a commit
that referenced
this pull request
Apr 7, 2021
* Fixed overwritten cosmos files * changelog * Fix typo in proto-compiler README * Fix bug where proto-compiler didn't find SDK repo if already cloned Co-authored-by: Romain Ruetschi <romain@informal.systems>
romac
added a commit
that referenced
this pull request
Apr 7, 2021
* Remove light client commands and configuration * Remove light client init code in scripts * Update the changelog * Use rpc_timeout field from chain config * Update config files and ADRs * Add --locked flag when compiling hermes in init-clients * Fix ibc-proto recompilation bug (#802) * Fixed overwritten cosmos files * changelog * Fix typo in proto-compiler README * Fix bug where proto-compiler didn't find SDK repo if already cloned Co-authored-by: Romain Ruetschi <romain@informal.systems> * Add option to specify which events to listen for in `listen` command (#804) * Update config_example.toml * Rename init-clients to init-hermes Co-authored-by: Adi Seredinschi <adi@informal.systems>
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Fixed overwritten cosmos files * changelog * Fix typo in proto-compiler README * Fix bug where proto-compiler didn't find SDK repo if already cloned Co-authored-by: Romain Ruetschi <romain@informal.systems>
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Remove light client commands and configuration * Remove light client init code in scripts * Update the changelog * Use rpc_timeout field from chain config * Update config files and ADRs * Add --locked flag when compiling hermes in init-clients * Fix ibc-proto recompilation bug (informalsystems#802) * Fixed overwritten cosmos files * changelog * Fix typo in proto-compiler README * Fix bug where proto-compiler didn't find SDK repo if already cloned Co-authored-by: Romain Ruetschi <romain@informal.systems> * Add option to specify which events to listen for in `listen` command (informalsystems#804) * Update config_example.toml * Rename init-clients to init-hermes Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: cosmos/ibc-proto-rs#11
Description
Added a safety check to prevent overwriting of cosmos-related files.
The problem is described here: https://github.com/informalsystems/ibc-rs/issues/801#issuecomment-814268643
Solution:
../proto/..., added a safety check to prevent overwriting ofcosmos.*filescosmos.*files are generated, only the original (from SDK) is retainedFor contributor use:
docs/) and code comments.Files changedin the Github PR explorer.