-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the keystore and override the account by the one in the key file after decoding the key from the mnemonic #810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes are good for now. If it's working on the tests and transactions are signed then should be OK. But probably for the next release we should look into the whole key support (keyring, sign_tx with cosmos_tx, allow to import keys with mnemonic).
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overall the changes are good, but just thinking if we should have the mnemonics under keys restore
I've did a quick test,
|
|
I think we should remove that for now. If one day we allow passing the account to sign the tx then we can allow that.
I don't think we need to ensure backward compatibility. I think the format is OK, in the end most people will just use the mnemonic option and only the relayer uses that imported key, there's no |
…file after decoding the key from the mnemonic (informalsystems#810)
Closes: #751
Closes: #636
Description
key restore
commandNote: This PR is best reviewed one commit at the time.
New interface of
keys add
New interface of
keys restore
For contributor use:
docs/
) and code comments.Files changed
in the Github PR explorer.