Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine the Tx gas that would be required before sending the Tx #945

Closed
wants to merge 1 commit into from
Closed

Determine the Tx gas that would be required before sending the Tx #945

wants to merge 1 commit into from

Conversation

ancazamfir
Copy link
Collaborator

Closes: #930

Description

  • add gRPC query to simulate Tx
  • if gas_used is higher than the config gas then do not sent the Tx

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@ancazamfir
Copy link
Collaborator Author

Incorporated in #1091

@ancazamfir ancazamfir closed this Jun 15, 2021
@ancazamfir ancazamfir deleted the anca/simulate_tx branch November 15, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Evaluate use of Tx simulate to determine the fees
1 participant
@ancazamfir