Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes tx CLIs that use packet_data_query_height should also clear begin/end block events #2868

Closed
5 tasks
ancazamfir opened this issue Nov 16, 2022 · 0 comments · Fixed by #2870
Closed
5 tasks
Assignees
Milestone

Comments

@ancazamfir
Copy link
Collaborator

ancazamfir commented Nov 16, 2022

Summary of Bug

cc @romac
While debugging issue #2867 in order to clear the stuck packets we tried to use the
hermes tx packet-recv ...--packet_data_query_height
in order to extract the events from block_results at exact height and relay those packets.
The problem is that the CLI only gets the packets from the tx events and not the begin and end block events.

Version

all

Steps to Reproduce

Currently this is not easy without a custom gaia or using the ICS testnet.
We should write integration tests if possible.

Acceptance Criteria

Retrieve all events (begin block, tx, end block events) and clear packets for all. This should be done for both packet-recv and packet-ack.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants