Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on master due to bitvec -> funty dependency #665

Closed
5 tasks
adizere opened this issue Feb 15, 2021 · 0 comments · Fixed by #666
Closed
5 tasks

Build fails on master due to bitvec -> funty dependency #665

adizere opened this issue Feb 15, 2021 · 0 comments · Fixed by #666
Assignees
Labels
A: bug Admin: something isn't working I: dependencies Internal: related to dependencies
Milestone

Comments

@adizere
Copy link
Member

adizere commented Feb 15, 2021

Crate

relayer

Summary of Bug

We depend on funty via bitvec.

├── k256 v0.7.2
│   ├── cfg-if v1.0.0
│   ├── ecdsa v0.10.2
│   │   ├── elliptic-curve v0.8.4
│   │   │   ├── bitvec v0.18.4
│   │   │   │   ├── funty v1.2.0
│   │   │   │   ├── radium v0.4.1
│   │   │   │   └── wyz v0.2.0
│   │   │   ├── digest v0.9.0 (*)
│   │   │   ├── ff v0.8.0
│   │   │   │   ├── bitvec v0.18.4 (*)
│   │   │   │   ├── rand_core v0.5.1 (*)
│   │   │   │   └── subtle v2.4.0

Crate funty recently had a breaking change release, which result in breaking bitvec, thus breaking relayer also.

A complete build log can be seen here: https://github.com/informalsystems/ibc-rs/actions/runs/568080453.

@ancazamfir found the quick fix, proposed in the funty repo, to pin to the previous version of funty.

$ g diff
diff --git a/relayer/Cargo.toml b/relayer/Cargo.toml
index 3f4b05f..05854b6 100644
--- a/relayer/Cargo.toml
+++ b/relayer/Cargo.toml
@@ -51,6 +51,7 @@ dyn-clonable = "0.9.0"
 tonic = "0.4"
 dirs-next = "2.0.0"
 dyn-clone = "1.0.3"
+funty="=1.1.0"
 [dependencies.tendermint]
 version = "=0.18.0"

It would be ideal to eventually undo this quick fix.

Related -- a few other crates report the same build breaking with the new funty 1.2: ferrilab/funty#3


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added A: bug Admin: something isn't working I: dependencies Internal: related to dependencies labels Feb 15, 2021
@adizere adizere added this to the v0.1.1 milestone Feb 15, 2021
@adizere adizere self-assigned this Feb 15, 2021
This was referenced Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working I: dependencies Internal: related to dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant