Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes failing to compile #672

Closed
5 tasks
Fraccaman opened this issue Feb 16, 2021 · 3 comments · Fixed by #684
Closed
5 tasks

Hermes failing to compile #672

Fraccaman opened this issue Feb 16, 2021 · 3 comments · Fixed by #684
Assignees
Labels
A: blocked Admin: blocked by another (internal/external) issue or PR A: bug Admin: something isn't working I: dependencies Internal: related to dependencies I: guide Internal: issues with the Hermes guide
Milestone

Comments

@Fraccaman
Copy link

Crate

  • ibc-relayer-cli

Summary of Bug

Following the guide here, building hermes either from source or using cargo, leads to compile errors.
Here the error logs: pastebin

Version

  • cargo: cargo 1.50.0 (f04e7fab7 2021-02-04)
  • rustc: rustc 1.50.0 (cb75ad5db 2021-02-10)
  • hermes: v0.1.0

Steps to Reproduce

  • cargo install ibc-relayer-cli

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere
Copy link
Member

adizere commented Feb 16, 2021

Hi, thank you for opening this issue.

Intuitively, the problem is that an indirect dependency (funty) of crate ibc-relayer-cli had a minor-version update recently, which is causing build errors in release v0.1.0. We have solved this problem, but did not release a new version since then.

The simplest way to mitigate this would be to build Hermes from source -- as documented in here, but ignore the following step:

git checkout v0.1.0

Instead, no need to check-out any specific release (just use master, the default version that is checked-out when you clone the repo).

@Fraccaman
Copy link
Author

Okay, thanks! On master is compiling without any error.

@adizere adizere added A: blocked Admin: blocked by another (internal/external) issue or PR A: bug Admin: something isn't working I: dependencies Internal: related to dependencies I: documentation Internal: improvements or additions to documentation labels Feb 16, 2021
@adizere
Copy link
Member

adizere commented Feb 16, 2021

Great!

We will update the documentation shortly to mention this problem & workaround explicitly.

@adizere adizere self-assigned this Feb 16, 2021
@adizere adizere added this to the v0.1.1 milestone Feb 16, 2021
@adizere adizere added I: guide Internal: issues with the Hermes guide and removed I: documentation Internal: improvements or additions to documentation labels Feb 18, 2021
@adizere adizere modified the milestones: v0.1.1, 03.2021 Feb 18, 2021
adizere added a commit that referenced this issue Feb 19, 2021
adizere added a commit that referenced this issue Feb 23, 2021
* Fix for issue #672 in the guide

* Apply suggestions from code review

Co-authored-by: Romain Ruetschi <romain@informal.systems>

* Simplified description. Added locked by default

* changelog

Co-authored-by: Romain Ruetschi <romain@informal.systems>
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this issue Sep 13, 2022
* Fix for issue informalsystems#672 in the guide

* Apply suggestions from code review

Co-authored-by: Romain Ruetschi <romain@informal.systems>

* Simplified description. Added locked by default

* changelog

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: blocked Admin: blocked by another (internal/external) issue or PR A: bug Admin: something isn't working I: dependencies Internal: related to dependencies I: guide Internal: issues with the Hermes guide
Projects
None yet
2 participants