Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved installation guide #684

Merged
merged 7 commits into from
Feb 23, 2021
Merged

Improved installation guide #684

merged 7 commits into from
Feb 23, 2021

Conversation

adizere
Copy link
Member

@adizere adizere commented Feb 19, 2021

Closes: #672


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@codecov-io
Copy link

codecov-io commented Feb 19, 2021

Codecov Report

Merging #684 (4c77e58) into master (b1b37f5) will increase coverage by 30.5%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #684      +/-   ##
=========================================
+ Coverage    13.6%   44.2%   +30.5%     
=========================================
  Files          69     150      +81     
  Lines        3752    9776    +6024     
  Branches     1374       0    -1374     
=========================================
+ Hits          513    4325    +3812     
- Misses       2618    5451    +2833     
+ Partials      621       0     -621     
Impacted Files Coverage Δ
modules/src/address.rs 100.0% <ø> (ø)
...application/ics20_fungible_token_transfer/error.rs 0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs 0.0% <ø> (ø)
modules/src/events.rs 0.0% <ø> (ø)
modules/src/handler.rs 100.0% <ø> (ø)
modules/src/ics02_client/client_def.rs 48.3% <ø> (ø)
modules/src/ics02_client/client_type.rs 79.1% <ø> (+31.5%) ⬆️
modules/src/ics02_client/context.rs 100.0% <ø> (ø)
modules/src/ics02_client/error.rs 100.0% <ø> (ø)
modules/src/ics02_client/events.rs 15.7% <ø> (+15.7%) ⬆️
... and 255 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36abaa...8e06ea3. Read the comment docs.

guide/src/installation.md Outdated Show resolved Hide resolved
guide/src/installation.md Outdated Show resolved Hide resolved
guide/src/installation.md Outdated Show resolved Hide resolved
guide/src/installation.md Outdated Show resolved Hide resolved
guide/src/installation.md Outdated Show resolved Hide resolved
guide/src/installation.md Outdated Show resolved Hide resolved
@adizere adizere merged commit 7011aa8 into master Feb 23, 2021
@adizere adizere deleted the adi/672_install branch February 23, 2021 13:16
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Fix for issue informalsystems#672 in the guide

* Apply suggestions from code review

Co-authored-by: Romain Ruetschi <romain@informal.systems>

* Simplified description. Added locked by default

* changelog

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hermes failing to compile
3 participants