Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rm unnecessary code for eureka #1372

Open
wants to merge 17 commits into
base: rano/eureka/1364
Choose a base branch
from
Prev Previous commit
Next Next commit
redundant comments
rnbguy committed Oct 24, 2024

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
commit c4f07dee554cfd31388f614c8639e03eb35fb51c
25 changes: 0 additions & 25 deletions ibc-eureka-core/ics25-handler/types/src/msgs.rs
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@
/// Enumeration of all messages that the local ICS26 module is capable of routing.
#[cfg_attr(
feature = "borsh",
derive(borsh::BorshSerialize, borsh::BorshDeserialize)

Check warning on line 19 in ibc-eureka-core/ics25-handler/types/src/msgs.rs

Codecov / codecov/patch

ibc-eureka-core/ics25-handler/types/src/msgs.rs#L19

Added line #L19 was not covered by tests
)]
#[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
#[derive(Clone, Debug, PartialEq, Eq, derive_more::From)]
@@ -30,71 +30,46 @@
impl TryFrom<Any> for MsgEnvelope {
type Error = DecodingError;

fn try_from(any_msg: Any) -> Result<Self, Self::Error> {
match any_msg.type_url.as_str() {
// ICS2 messages
CREATE_CLIENT_TYPE_URL => {

Check warning on line 36 in ibc-eureka-core/ics25-handler/types/src/msgs.rs

Codecov / codecov/patch

ibc-eureka-core/ics25-handler/types/src/msgs.rs#L33-L36

Added lines #L33 - L36 were not covered by tests
// Pop out the message and then wrap it in the corresponding type.
let domain_msg = MsgCreateClient::decode_vec(&any_msg.value)?;
Ok(MsgEnvelope::Client(ClientMsg::CreateClient(domain_msg)))

Check warning on line 39 in ibc-eureka-core/ics25-handler/types/src/msgs.rs

Codecov / codecov/patch

ibc-eureka-core/ics25-handler/types/src/msgs.rs#L38-L39

Added lines #L38 - L39 were not covered by tests
}
UPDATE_CLIENT_TYPE_URL => {
let domain_msg = MsgUpdateClient::decode_vec(&any_msg.value)?;
Ok(MsgEnvelope::Client(ClientMsg::UpdateClient(domain_msg)))

Check warning on line 43 in ibc-eureka-core/ics25-handler/types/src/msgs.rs

Codecov / codecov/patch

ibc-eureka-core/ics25-handler/types/src/msgs.rs#L41-L43

Added lines #L41 - L43 were not covered by tests
}
UPGRADE_CLIENT_TYPE_URL => {
let domain_msg = MsgUpgradeClient::decode_vec(&any_msg.value)?;
Ok(MsgEnvelope::Client(ClientMsg::UpgradeClient(domain_msg)))

Check warning on line 47 in ibc-eureka-core/ics25-handler/types/src/msgs.rs

Codecov / codecov/patch

ibc-eureka-core/ics25-handler/types/src/msgs.rs#L45-L47

Added lines #L45 - L47 were not covered by tests
}
SUBMIT_MISBEHAVIOUR_TYPE_URL => {
let domain_msg = MsgSubmitMisbehaviour::decode_vec(&any_msg.value)?;
Ok(MsgEnvelope::Client(ClientMsg::Misbehaviour(domain_msg)))

Check warning on line 51 in ibc-eureka-core/ics25-handler/types/src/msgs.rs

Codecov / codecov/patch

ibc-eureka-core/ics25-handler/types/src/msgs.rs#L49-L51

Added lines #L49 - L51 were not covered by tests
}

// // ICS04 channel messages
// CHAN_OPEN_INIT_TYPE_URL => {
// let domain_msg = MsgChannelOpenInit::decode_vec(&any_msg.value)?;
// Ok(MsgEnvelope::Channel(ChannelMsg::OpenInit(domain_msg)))
// }
// CHAN_OPEN_TRY_TYPE_URL => {
// let domain_msg = MsgChannelOpenTry::decode_vec(&any_msg.value)?;
// Ok(MsgEnvelope::Channel(ChannelMsg::OpenTry(domain_msg)))
// }
// CHAN_OPEN_ACK_TYPE_URL => {
// let domain_msg = MsgChannelOpenAck::decode_vec(&any_msg.value)?;
// Ok(MsgEnvelope::Channel(ChannelMsg::OpenAck(domain_msg)))
// }
// CHAN_OPEN_CONFIRM_TYPE_URL => {
// let domain_msg = MsgChannelOpenConfirm::decode_vec(&any_msg.value)?;
// Ok(MsgEnvelope::Channel(ChannelMsg::OpenConfirm(domain_msg)))
// }
// CHAN_CLOSE_INIT_TYPE_URL => {
// let domain_msg = MsgChannelCloseInit::decode_vec(&any_msg.value)?;
// Ok(MsgEnvelope::Channel(ChannelMsg::CloseInit(domain_msg)))
// }
// CHAN_CLOSE_CONFIRM_TYPE_URL => {
// let domain_msg = MsgChannelCloseConfirm::decode_vec(&any_msg.value)?;
// Ok(MsgEnvelope::Channel(ChannelMsg::CloseConfirm(domain_msg)))
// }
// ICS04 packet messages
RECV_PACKET_TYPE_URL => {
let domain_msg = MsgRecvPacket::decode_vec(&any_msg.value)?;
Ok(MsgEnvelope::Packet(PacketMsg::Recv(domain_msg)))

Check warning on line 57 in ibc-eureka-core/ics25-handler/types/src/msgs.rs

Codecov / codecov/patch

ibc-eureka-core/ics25-handler/types/src/msgs.rs#L55-L57

Added lines #L55 - L57 were not covered by tests
}
ACKNOWLEDGEMENT_TYPE_URL => {
let domain_msg = MsgAcknowledgement::decode_vec(&any_msg.value)?;
Ok(MsgEnvelope::Packet(PacketMsg::Ack(domain_msg)))

Check warning on line 61 in ibc-eureka-core/ics25-handler/types/src/msgs.rs

Codecov / codecov/patch

ibc-eureka-core/ics25-handler/types/src/msgs.rs#L59-L61

Added lines #L59 - L61 were not covered by tests
}
TIMEOUT_TYPE_URL => {
let domain_msg = MsgTimeout::decode_vec(&any_msg.value)?;
Ok(MsgEnvelope::Packet(PacketMsg::Timeout(domain_msg)))

Check warning on line 65 in ibc-eureka-core/ics25-handler/types/src/msgs.rs

Codecov / codecov/patch

ibc-eureka-core/ics25-handler/types/src/msgs.rs#L63-L65

Added lines #L63 - L65 were not covered by tests
}
TIMEOUT_ON_CLOSE_TYPE_URL => {
let domain_msg = MsgTimeoutOnClose::decode_vec(&any_msg.value)?;
Ok(MsgEnvelope::Packet(PacketMsg::TimeoutOnClose(domain_msg)))

Check warning on line 69 in ibc-eureka-core/ics25-handler/types/src/msgs.rs

Codecov / codecov/patch

ibc-eureka-core/ics25-handler/types/src/msgs.rs#L67-L69

Added lines #L67 - L69 were not covered by tests
}

_ => Err(DecodingError::UnknownTypeUrl(any_msg.type_url))?,

Check warning on line 72 in ibc-eureka-core/ics25-handler/types/src/msgs.rs

Codecov / codecov/patch

ibc-eureka-core/ics25-handler/types/src/msgs.rs#L72

Added line #L72 was not covered by tests
}
}

Check warning on line 74 in ibc-eureka-core/ics25-handler/types/src/msgs.rs

Codecov / codecov/patch

ibc-eureka-core/ics25-handler/types/src/msgs.rs#L74

Added line #L74 was not covered by tests
}
Loading