Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tendermint v0.17.1 #516

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Update to tendermint v0.17.1 #516

merged 4 commits into from
Jan 12, 2021

Conversation

romac
Copy link
Member

@romac romac commented Jan 12, 2021

Closes: #517

Description

  • Update the tendermint-rs dependencies to v0.17.1
  • Update the patch.crates-io workspace override to point to the ibc branch in tendermint-rs (which includes backward verification)
  • Add a missing .into() call (not clear why that's only just broken down)

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac requested a review from ancazamfir January 12, 2021 14:44
Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Romain!

@ancazamfir
Copy link
Collaborator

Doh! Just got a panic doing more packet testing.

...
Jan 12 16:38:52.274  INFO relayer::event::monitor: running listener chain.id=ibc-1
Jan 12 16:38:52.338  INFO relayer::event::monitor: running listener chain.id=ibc-0
Jan 12 16:38:53.045  INFO relayer::link: packets that still have commitments on source ibc-1: [11, 12]
Jan 12 16:38:53.666  INFO relayer::link: packets to send out of the ones with commitments on source [Sequence(11), Sequence(12)]
Jan 12 16:38:56.270  INFO relayer::link: received from query_txs [Sequence(11), Sequence(12)]
Jan 12 16:38:56.270  INFO relayer::link: ibc-1 => event block::Height(13291) send_packet PortId("transfer") ChannelId("channel-0") Sequence(11)
Jan 12 16:38:57.329  INFO relayer::link: built recv_packet msg PortId("transfer") ChannelId("channel-0") Sequence(11), proofs at height Height { revision_number: 1, revision_height: 13292 }
Jan 12 16:38:57.329  INFO relayer::link: ibc-1 => event block::Height(13291) send_packet PortId("transfer") ChannelId("channel-0") Sequence(12)
Jan 12 16:38:58.423  INFO relayer::link: built recv_packet msg PortId("transfer") ChannelId("channel-0") Sequence(12), proofs at height Height { revision_number: 1, revision_height: 13292 }

The application panicked (crashed).
Message:  called `Option::unwrap()` on a `None` value
Location: /Users/ancaz/.cargo/git/checkouts/tendermint-rs-7b2e4433a0119a31/551ba8c/proto/src/serializers/evidence.rs:32

Run with RUST_BACKTRACE=full to include source snippets.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                         (12 post panic frames hidden)
12: core::panicking::panic::hd1044393afd25972
    at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/core/src/panicking.rs:50
13: core::option::Option<T>::unwrap::h79a4bcbef9112f09
    at /Users/ancaz/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/option.rs:386
14: <tendermint_proto::serializers::evidence::EvidenceVariant as core::convert::From<tendermint_proto::tendermint::types::Evidence>>::from::h2a110edd252ee0c7
    at /Users/ancaz/.cargo/git/checkouts/tendermint-rs-7b2e4433a0119a31/551ba8c/proto/src/serializers/evidence.rs:32
15: <T as core::convert::Into<U>>::into::h8d8a33357603f032
    at /Users/ancaz/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/convert/mod.rs:546
16: tendermint_proto::tendermint::types::_::<impl serde::ser::Serialize for tendermint_proto::tendermint::types::Evidence>::serialize::h202fc39c59df7544
    at /Users/ancaz/.cargo/git/checkouts/tendermint-rs-7b2e4433a0119a31/551ba8c/proto/src/prost/tendermint.types.rs:367
17: tendermint::evidence::_::<impl serde::ser::Serialize for tendermint::evidence::Evidence>::serialize::h48e12519a260fe6c
    at /Users/ancaz/.cargo/git/checkouts/tendermint-rs-7b2e4433a0119a31/551ba8c/tendermint/src/evidence.rs:23
18: <serde_json::ser::Compound<W,F> as serde::ser::SerializeMap>::serialize_value::h7b11b22383c15fd7
    at /Users/ancaz/.cargo/registry/src/github.com-1ecc6299db9ec823/serde_json-1.0.61/src/ser.rs:716
19: serde::ser::SerializeMap::serialize_entry::h5d1c6ee2fecfe9d4
    at /Users/ancaz/.cargo/registry/src/github.com-1ecc6299db9ec823/serde-1.0.118/src/ser/mod.rs:1823
20: <serde_json::ser::Compound<W,F> as serde::ser::SerializeStruct>::serialize_field::hcb73ba6b7abd2ef1
    at /Users/ancaz/.cargo/registry/src/github.com-1ecc6299db9ec823/serde_json-1.0.61/src/ser.rs:762
21: tendermint_rpc::endpoint::evidence::_::<impl serde::ser::Serialize for tendermint_rpc::endpoint::evidence::Request>::serialize::hc12a5d02fba1f357
    at /Users/ancaz/.cargo/git/checkouts/tendermint-rs-7b2e4433a0119a31/551ba8c/rpc/src/endpoint/evidence.rs:9
22: <serde_json::ser::Compound<W,F> as serde::ser::SerializeMap>::serialize_value::h0a21d54f0633ba56
    at /Users/ancaz/.cargo/registry/src/github.com-1ecc6299db9ec823/serde_json-1.0.61/src/ser.rs:716
23: serde::ser::SerializeMap::serialize_entry::h8880a90eed86b72a
    at /Users/ancaz/.cargo/registry/src/github.com-1ecc6299db9ec823/serde-1.0.118/src/ser/mod.rs:1823
24: <serde_json::ser::Compound<W,F> as serde::ser::SerializeStruct>::serialize_field::he84a69f9f4e5c126
    at /Users/ancaz/.cargo/registry/src/github.com-1ecc6299db9ec823/serde_json-1.0.61/src/ser.rs:762
25: tendermint_rpc::request::_::<impl serde::ser::Serialize for tendermint_rpc::request::Wrapper<R>>::serialize::h0b692040105d77a2
    at /Users/ancaz/.cargo/git/checkouts/tendermint-rs-7b2e4433a0119a31/551ba8c/rpc/src/request.rs:32
26: serde_json::ser::to_writer_pretty::he655794cc1d4fae1
    at /Users/ancaz/.cargo/registry/src/github.com-1ecc6299db9ec823/serde_json-1.0.61/src/ser.rs:2176
27: serde_json::ser::to_vec_pretty::h23437c91c9b8e09a
    at /Users/ancaz/.cargo/registry/src/github.com-1ecc6299db9ec823/serde_json-1.0.61/src/ser.rs:2208
28: serde_json::ser::to_string_pretty::h60d2294caa1a04dd

@romac
Copy link
Member Author

romac commented Jan 12, 2021

Doh! Just got a panic doing more packet testing.

This is due to the fork detector being re-enabled in this branch (we don't bypass the supervisor anymore). As discussed on Slack, let's merge as-is and track+fix this issue separately.

@romac romac merged commit 5e9c1d6 into master Jan 12, 2021
@romac romac deleted the romac/tendermint-0.17.1 branch January 12, 2021 17:38
@romac
Copy link
Member Author

romac commented Jan 14, 2021

Doh! Just got a panic doing more packet testing.

This is due to the fork detector being re-enabled in this branch (we don't bypass the supervisor anymore). As discussed on Slack, let's merge as-is and track+fix this issue separately.

Tracked on the tendermint-rs side in informalsystems/tendermint-rs#782

hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Update to tendermint-rs v0.17.1

* Add missing call to .into()

* Update changelog

* Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tendermint-rs dependencies to v0.17.1
2 participants