-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic in evidence serializers #782
Labels
Comments
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The serializers for
tendermint::types::{Evidence, evidence::Sum}
are incomplete and may cause a panic in the relayer.The panic happens in this
From
instance, which should likely be converted to aTryFrom
instance:tendermint-rs/proto/src/serializers/evidence.rs
Lines 30 to 38 in 4cbf727
Additionally, these
From
instances are currentlyunimplemented!
:tendermint-rs/proto/src/serializers/evidence.rs
Lines 40 to 50 in 4cbf727
The comment seems to imply they won't ever be called, so it shouldn't be a problem, but perhaps it would worth looking into removing them altogether while we're at it.
The text was updated successfully, but these errors were encountered: