Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [crate] Make Model Connection as newtype u64 #544

Closed
wants to merge 7 commits into from

Conversation

DaviRain-Su
Copy link
Contributor

Closes: #543

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 77.41% and project coverage change: -0.07 ⚠️

Comparison is base (e7f02ac) 72.90% compared to head (709584c) 72.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
- Coverage   72.90%   72.84%   -0.07%     
==========================================
  Files         126      126              
  Lines       15594    15597       +3     
==========================================
- Hits        11369    11361       -8     
- Misses       4225     4236      +11     
Impacted Files Coverage Δ
...src/core/ics04_channel/events/packet_attributes.rs 10.55% <0.00%> (-0.27%) ⬇️
.../src/core/ics04_channel/handler/acknowledgement.rs 87.08% <0.00%> (ø)
.../ibc/src/core/ics04_channel/handler/recv_packet.rs 87.41% <0.00%> (ø)
crates/ibc/src/core/ics24_host/error.rs 0.00% <ø> (ø)
crates/ibc/src/core/ics24_host/identifier.rs 60.61% <44.44%> (-1.77%) ⬇️
crates/ibc/src/core/ics04_channel/channel.rs 54.07% <50.00%> (ø)
.../src/core/ics04_channel/handler/chan_close_init.rs 81.48% <50.00%> (ø)
...c/core/ics04_channel/handler/chan_close_confirm.rs 91.37% <75.00%> (ø)
...bc/src/core/ics04_channel/handler/chan_open_try.rs 89.86% <75.00%> (ø)
...bc/src/core/ics04_channel/handler/chan_open_ack.rs 94.33% <80.00%> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@plafer
Copy link
Contributor

plafer commented Mar 23, 2023

Unfortunately, we'll have to close this as this is not a desired change (see comment in issue)

@plafer plafer closed this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[crate] Make Model Connection as newtype u64
2 participants