Relax uppercase check for types qualified with a namespace

[romac]

Closes: #1494

Allows type foo::Bar = int whereas it would previously fail with type names must start with an uppercase letter because the check was looking at the very first letter of the fully qualified name (ie. foo::Bar) instead of the unqualified name (ie. Bar).

Example

module upper {
  type Foo = int
  type foo = int

  type foo::Bar = int
  type foo::bar = int
}

Before

upper.qnt:2:3 - error: [QNT007] type names must start with an uppercase letter
2:   type Foo = int
     ^^^^^^^^^^^^^^

upper.qnt:3:3 - error: [QNT007] type names must start with an uppercase letter
3:   type foo = int
     ^^^^^^^^^^^^^^

upper.qnt:5:3 - error: [QNT007] type names must start with an uppercase letter
5:   type foo::Bar = int
     ^^^^^^^^^^^^^^^^^^^

upper.qnt:6:3 - error: [QNT007] type names must start with an uppercase letter
6:   type foo::bar = int
     ^^^^^^^^^^^^^^^^^^^

error: parsing failed

After

/Users/romac/Informal/Code/quint/quint/upper.qnt:3:3 - error: [QNT007] type names must start with an uppercase letter
3:   type foo = int
     ^^^^^^^^^^^^^^

/Users/romac/Informal/Code/quint/quint/upper.qnt:5:3 - error: [QNT007] type names must start with an uppercase letter
5:   type foo::bar = int
     ^^^^^^^^^^^^^^^^^^^

error: parsing failed

---

• Tests added for any new code
• Documentation added for any new functionality
• Entries added to the respective CHANGELOG.md for any new functionality
• Feature table on README.md updated for any listed functionality

[bugarela]

This is great! I think we can easily add a unit test for this: we can just add a type declaration with the new supported name pattern to SuperSpec.qnt and then update the expected fixtures with npm run update-fixtures. If all works well, the new fixture will be only slightly different, but still a success - while before, a type like that would cause errors. It is not a really good unit test setup, but at least it will prevent us from regressing from this.

[romac]

On CI, the quint-test-generated-up-to-date is failing with

ERROR: Generated files are not up to date. Run 'npm run generate'

But when I run the suggested command I don't see any changes in my working copy

[bugarela]

On CI, the quint-test-generated-up-to-date is failing with

ERROR: Generated files are not up to date. Run 'npm run generate'

But when I run the suggested command I don't see any changes in my working copy

Unfortunately this command (or the npm run update-fixtures which is part of it) generates also files that are not relevant to us, and are not tracked by git, so what I do is not commit them and run git clean -f testFixture/* to remove them from my working copy. I see that you committed those files in your last commit, and that's is likely what is causing the CI to break.

Can you remove those extra files? All of them but the SuperSpec* ones. Then I think it will work.

[romac]

I see that you committed those files in your last commit

Indeed, my bad sorry! Fixed now.

[bugarela]

Amazing, thanks again!