Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option --apalache-version to quint verify #1521

Merged
merged 7 commits into from
Oct 3, 2024

Conversation

konnov
Copy link
Contributor

@konnov konnov commented Oct 2, 2024

Since every release of Apalache requires a PR in Quint, this PR introduces the option --apalache-version. This option allows the Quint users to pull different versions of Apalache without waiting for a new release of Quint. For instance, the new version of Apalache v0.47.0 downgrades the version of z3.

  • Entries added to the respective CHANGELOG.md for any new functionality

@konnov konnov marked this pull request as ready for review October 2, 2024 19:30
@konnov
Copy link
Contributor Author

konnov commented Oct 2, 2024

The failing integration tests does not seem to do with the PR. Is it a flaky test?

@bugarela
Copy link
Collaborator

bugarela commented Oct 3, 2024

The failing integration tests does not seem to do with the PR. Is it a flaky test?

It is. Idk why, but sometimes the file disappears before we remove it or something. I'll run it again, that usually fixes it. I still need to figure out what is happening and find a proper fix.

Copy link
Collaborator

@bugarela bugarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks useful, specially for us Quint/Apalache devs. I just added a suggestion on the option description.

quint/src/cli.ts Outdated Show resolved Hide resolved
quint/src/cli.ts Outdated Show resolved Hide resolved
konnov and others added 2 commits October 3, 2024 13:17
Co-authored-by: Gabriela Moreira <gabrielamoreira05@gmail.com>
Co-authored-by: Gabriela Moreira <gabrielamoreira05@gmail.com>
@konnov
Copy link
Contributor Author

konnov commented Oct 3, 2024

Yep, just committed your suggestions. Feel free to merge!

@bugarela bugarela enabled auto-merge October 3, 2024 11:20
@bugarela bugarela merged commit 48ab15c into informalsystems:main Oct 3, 2024
14 checks passed
@bugarela bugarela mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants