Clippy fixes (#868)

* Clippy-check improvement warnings->errors

* Naming clarification

* Clippy fix

* Even more naming conventions

* Revert "Even more naming conventions"

This reverts commit 394dcd9.

* Clippy fix

.github/workflows/rust.yml

@@ -30,7 +30,8 @@ jobs:
           command: fmt
           args: --all -- --check
 
-  clippy_check:
+  # This job creates the "clippy-results" GitHub Action that lists the clippy results in a nice format.
+  clippy-json-output:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -41,8 +42,9 @@ jobs:
           override: true
       - uses: actions-rs/clippy-check@v1
         with:
+          name: clippy-results
           token: ${{ secrets.GITHUB_TOKEN }}
-          args: --all-features --all-targets
+          args: --all-features --all-targets -- -Dwarnings -Drust-2018-idioms
 
   docs:
     runs-on: ubuntu-latest

light-client-js/src/lib.rs

@@ -24,7 +24,7 @@ use wasm_bindgen::JsValue;
 // allocator.
 #[cfg(feature = "wee_alloc")]
 #[global_allocator]
-static ALLOC: wee_alloc::WeeAlloc = wee_alloc::WeeAlloc::INIT;
+static ALLOC: wee_alloc::WeeAlloc<'_> = wee_alloc::WeeAlloc::INIT;
 
 /// Check whether a given untrusted block can be trusted.
 #[wasm_bindgen]

proto/src/serializers/part_set_header_total.rs

@@ -30,7 +30,7 @@ where
 impl<'de> Visitor<'de> for PartSetHeaderTotalStringOrU32 {
     type Value = u32;
 
-    fn expecting(&self, formatter: &mut Formatter) -> std::fmt::Result {
+    fn expecting(&self, formatter: &mut Formatter<'_>) -> std::fmt::Result {
         formatter.write_str("an u32 integer or string between 0 and 2^32")
     }