Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light client crate structure #136

Closed
3 of 7 tasks
ebuchman opened this issue Feb 2, 2020 · 2 comments
Closed
3 of 7 tasks

Light client crate structure #136

ebuchman opened this issue Feb 2, 2020 · 2 comments
Labels
light-client Issues/features which involve the light client
Milestone
v0.15.0

Comments

@ebuchman
Copy link
Member

ebuchman commented Feb 2, 2020 •
edited by romac
Loading

Follow up to #110 Module Structure:

  • lite -> light
  • Remove dependency of light on tendermint::Hash
  • Move light to be its own crate in the workspace
  • Rename light_impl -> light (since the old light will be moved up into its own crate)
  • Rename light/types.rs to light/interface.rs and break out an errors.rs (Light client: bisection, store, requester #100 (comment))
  • Add example to doc
  • Unpublicize verify_commit_full and verify_commit_trusting (6bf0675)
@ebuchman ebuchman mentioned this issue Feb 2, 2020
Closed
22 tasks
liamsi added a commit that referenced this issue Feb 10, 2020
@liamsi
unpublicize verify_commit_full and verify_commit_trusting (ref #136)
6bf0675
Shivani912 added a commit that referenced this issue Feb 19, 2020
@liamsi @Shivani912
Valid TrustThresholdFraction and further simplify tests code (#142)
afcf99a 
* Valid TrustThresholdFraction for real

* Further simplify tests: init requester with final state

* Apply review suggestions and assert_bisection_err fn

* remove redundant clone

* add another err case

* unpublicize verify_commit_full and verify_commit_trusting (ref #136)

* ensure the untrusted_header.bft_time() > trusted_header.bft_time()

* Fix failing test and test and add another erroring one

* remove dupl test

* Consistent comments in tests

* Refactor init_requester (#152)

* added bisection test for insufficient commits

* refactored init_requester, TODO: update tests

* fixed tests

* Added bisection test for insufficient commits

* fixed failures

* cargo fmt

* Changed tests to use ValsAndCommit struct

* satisfy clippy

* Dealing with the merge conflict's aftermath

Co-authored-by: Shivani Joshi <46731446+Shivani912@users.noreply.github.com>
@romac romac added the light-client Issues/features which involve the light client label May 25, 2020
@romac romac mentioned this issue May 25, 2020
Closed
19 tasks
@ebuchman ebuchman added this to the Light Node milestone Jun 2, 2020
@ebuchman
Copy link
Member Author

ebuchman commented Jun 2, 2020

Some of the specifics are different since the refactor but we still generally need to clean up and ultimately deduplicate.

Also the refactored light client has very heavy dependency on tendermint data types (contrary to initial goals re the relationship between light and tendermint crates, ie. #110 (comment)) and it looks like this will not be trivial to change .... will probably open a separate issue for...

@ebuchman
Copy link
Member Author

Effectively replaced by #342 (dedup) and #387 (reduce dependency)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
light-client Issues/features which involve the light client
Projects
None yet
Milestone
v0.15.0
Development

No branches or pull requests
2 participants
@romac @ebuchman