-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pending Go changes] CommitSig validator address missing in Absent vote #260
Comments
Thanks @greg-szabo . If and when this is changed in the Go, it will be breaking, and we can open a new issue for it then, since it otherwise seems we've addressed it for now. Also as per tendermint/tendermint#4797 (comment), not sure this ever will be addressed, especially since we might look to remove ValidatorAddress from all CommitSigs! Let's close this then? |
I'm closing this. Feel free to re-open if you feel we should keep it open @greg-szabo. |
Go implementation
In CommitSig, in the BlockIDFlagAbsent type, the validator address field is expected to be missing.
ADR-025
The validator address field in Absent signatures should be present. (The validator address field should always be present.)
Current Rust implemenation
Rust implemented the ADR.
Problem
Tendermint-Rust is incompatible with Tendermint-Go.
Solution
The text was updated successfully, but these errors were encountered: