Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance tests compatibility issues #266

Closed
Shivani912 opened this issue May 11, 2020 · 0 comments
Closed

Conformance tests compatibility issues #266

Shivani912 opened this issue May 11, 2020 · 0 comments
Assignees

Comments

@Shivani912
Copy link
Contributor

Context

Problem
Since the conformance tests (JSON-based tests) are generated using the Go implementation, these incompatibilities make four of the Commit tests fail on deserialization. These are:

  • one-third vals don't sign (both under single-step sequential and skipping)
  • more than two-third vals did sign (both under single-step sequential and skipping)

Proposed Solution
After a good discussion with @greg-szabo and @liamsi on this, it was decided to identify and run these tests separately where we let it fail on deserialization for now with an added warning about the issues around it.
This way, we wouldn't have to makes changes to our code that are not acceptable i.e. accept an AbsentCommitSig without ValidatorAddress in this case. Also, once the issue is fixed on the Go implementation side, we'll be able to run these tests normally.

@Shivani912 Shivani912 self-assigned this May 11, 2020
@greg-szabo greg-szabo mentioned this issue May 21, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants