You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem
Since the conformance tests (JSON-based tests) are generated using the Go implementation, these incompatibilities make four of the Commit tests fail on deserialization. These are:
one-third vals don't sign (both under single-step sequential and skipping)
more than two-third vals did sign (both under single-step sequential and skipping)
Proposed Solution
After a good discussion with @greg-szabo and @liamsi on this, it was decided to identify and run these tests separately where we let it fail on deserialization for now with an added warning about the issues around it.
This way, we wouldn't have to makes changes to our code that are not acceptable i.e. accept an AbsentCommitSig without ValidatorAddress in this case. Also, once the issue is fixed on the Go implementation side, we'll be able to run these tests normally.
The text was updated successfully, but these errors were encountered:
Context
Problem
Since the conformance tests (JSON-based tests) are generated using the Go implementation, these incompatibilities make four of the
Commit
tests fail on deserialization. These are:Proposed Solution
After a good discussion with @greg-szabo and @liamsi on this, it was decided to identify and run these tests separately where we let it fail on deserialization for now with an added warning about the issues around it.
This way, we wouldn't have to makes changes to our code that are not acceptable i.e. accept an
AbsentCommitSig
withoutValidatorAddress
in this case. Also, once the issue is fixed on the Go implementation side, we'll be able to run these tests normally.The text was updated successfully, but these errors were encountered: