Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Secret Connection crate back to KMS #27

Closed
ebuchman opened this issue Sep 7, 2019 · 2 comments
Closed

Move Secret Connection crate back to KMS #27

ebuchman opened this issue Sep 7, 2019 · 2 comments

Comments

@ebuchman
Copy link
Member

ebuchman commented Sep 7, 2019 •
edited
Loading

Secret Connection is a bit heavy duty for this library. It's currently needed by the KMS, and will likely see some upgrades in the near term that will need to be closely integrated with the KMS (ie. to support timeouts via async/await - #2). See also the relevant dependency issue #11 and PR #21.

We likely won't won't need Secret Connection here for a while as we're focusing first on the light client and deterministic simulation of reactors, and by the time we look to integrate with peers, with any luck, a libp2p solution will be ready for Tendermint adoption.
@tarcieri
Copy link
Contributor

tarcieri commented Sep 7, 2019

Moving this back would unblock KMS on #11 and allow us to experiment with solving timeouts with various async strategies

tarcieri pushed a commit to tendermint/tmkms that referenced this issue Oct 17, 2019
@tony-iqlusion
Vendor Secret Connection implementation (fixes informalsystems/tender…
cb5d39c 
…mint-rs#27)

This commit wires up the Secret Connection implementation, whose code is
otherwise by definition identical to the `tendermint-rs` v0.10 crate
today, as it used to live in this repo and was restored by reverting it
in commit 104bb82.

Otherwise this is the minimum necessary changes needed to use the
in-tree copy as opposed to `tendermint-rs`. It otherwise performs no
changes or upgrades other than the ones needed to make the code compile
and pass the latest `clippy`.
@tarcieri tarcieri mentioned this issue Oct 17, 2019
Merged
@tarcieri
Copy link
Contributor

tarcieri commented Oct 17, 2019 •
edited
Loading

PR open to move Secret Connection back to the KMS here:

tendermint/tmkms#365

After that lands, I'd suggest deleting the copy of Secret Connection in-tree in this repo, as well as removing ring (see #11) and x25519-dalek from the Cargo.toml dependencies, as this will unblock the Signatory upgrades Dependabot is trying to perform.

tarcieri added a commit to tendermint/tmkms that referenced this issue Oct 18, 2019
@tarcieri
Merge pull request #365 from tendermint/vendor-secret-connection
54b15ea 
Vendor Secret Connection (fixes informalsystems/tendermint-rs#27)
This was referenced Nov 6, 2019
Closed
Closed
Merged
@xla xla mentioned this issue Nov 20, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tarcieri @ebuchman