New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DuplicateVoteEvidence: remove pubkey field #300

Closed

liamsi opened this issue Jun 4, 2020 · 1 comment

Member

liamsi commented Jun 4, 2020 •

edited

Loading

DuplicateVoteEvidence has a field pubkey which does not exist on the go side:
tendermint/tendermint#4959 (comment)

liamsi mentioned this issue

Fix #241 evidence JSON format #242

Merged

Member Author

liamsi commented Jun 4, 2020

NVM, in 0.33.x this still has a pubkey field: https://github.com/tendermint/tendermint/blob/e22acc0f451805e9ceef588561b5877be0fb1614/types/evidence.go#L213-L217

Probably not worth top track this single breaking change in an issue. Closing again.

liamsi closed this as completed

liamsi mentioned this issue

Tendermint 0.34 compatibility #305

Closed

greg-szabo mentioned this issue

Remove DuplicateVoteEvidence PublicKey #502

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment