evidence: json tags for DuplicateVoteEvidence #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been
Thank you for your contribution to Tendermint! 🚀 |
tac0turtle
added
C:evidence
tac0turtle
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4959 +/- ##
==========================================
+ Coverage 63.35% 63.38% +0.03%
==========================================
Files 189 189
Lines 19583 19584 +1
==========================================
+ Hits 12407 12414 +7
+ Misses 6189 6184 -5
+ Partials 987 986 -1
|
liamsi
approved these changes
Jun 4, 2020
| VoteA *Vote | ||
| VoteB *Vote | ||
| VoteA *Vote `json:"vote_a"` | ||
| VoteB *Vote `json:"vote_b"` |
There was a problem hiding this comment.
👍 Looks like we need also need to remove the pubkey field in the rust version too: https://github.com/informalsystems/tendermint-rs/pull/242/files#r417475910
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add json tags to duplicate evidence
Closes: #4958