Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JSON formatting to 0.34 #505

Closed
greg-szabo opened this issue Aug 4, 2020 · 0 comments · Fixed by #563
Closed

Update JSON formatting to 0.34 #505

greg-szabo opened this issue Aug 4, 2020 · 0 comments · Fixed by #563
Assignees
@greg-szabo
Labels
dependencies Pull requests that update a dependency file serialization
Milestone
v0.17.0

Comments

@greg-szabo
Copy link
Member

It is yet unclear where JSON formatting has changed in Tendermint-Go 0.34. In this issue, we're going to find all occurrences and fix them for 0.34 compatibility.

As a stretch goal, we should cover all cases where JSON changed with a unit test.

#305
@xla xla added dependencies Pull requests that update a dependency file serialization labels Aug 4, 2020
@greg-szabo greg-szabo mentioned this issue Aug 26, 2020
Merged
5 tasks
@greg-szabo greg-szabo mentioned this issue Sep 9, 2020
Closed
5 tasks
@greg-szabo greg-szabo self-assigned this Sep 10, 2020
@greg-szabo greg-szabo mentioned this issue Sep 11, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg-szabo greg-szabo

Labels
dependencies Pull requests that update a dependency file serialization
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging a pull request may close this issue.

Tendermint JSON test case fixes informalsystems/tendermint-rs
2 participants
@xla @greg-szabo