Tendermint JSON test case fixes

[greg-szabo]

Closes #505

• Referenced an issue explaining the need for the change
• Updated all relevant documentation in docs
• Updated all code comments where relevant
• Wrote tests
• Updated CHANGELOG.md

[greg-szabo]

All right, this is ready for review. Some of the light-client tests had to be disabled that were affected because of the change in voting power ordering or protobuf-encoding. The light-client integration test was also lowered to one iteration (essentially disabled) until the voting power change is implemented. (#556 )
All other tests were fixed but it would be better to regenerate the JSON files.

[liamsi]

IMO it could have been better to disable single test cases in some kind of blacklist. That way the JSON files could have served as a source for test-cases (s.t. we can guarantee the new generated tests to come will contain at least the cases that we already had).
On the other hand, deleting the failing cases is a bit cleaner.

FYI @Shivani912 and @andrey-kuprianov

[liamsi]

Isn't this supposed to be ignored given the line in the gitignore above? _*/*

[greg-szabo]

No, the .gitignore only ignores the report folders that the test harness creates in case of failing tests. They look like this: _bisection/report, _simple/report, etc.

[andrey-kuprianov]

In fact, because the tests for the light client are now run with Testgen, it will ignore any files/folders starting with _

[andrey-kuprianov]

IMO it could have been better to disable single test cases in some kind of blacklist. That way the JSON files could have served as a source for test-cases (s.t. we can guarantee the new generated tests to come will contain at least the cases that we already had).
On the other hand, deleting the failing cases is a bit cleaner.

FYI @Shivani912 and @andrey-kuprianov

As I wrote above, Testgen will ignore any files or folders starting with _. So the easy way to disable a test or a set of tests, but to keep them at the same time, is to rename with _ in front.

[liamsi]

Same question about gitgnore.

[greg-szabo]

Same response. Gitignore only activates with an underscore in the folder name. Here, there is an underscore in the file name.

[liamsi]

Ah OK. I see. Thanks for the clarification.

[greg-szabo]

No test cases were deleted. The test harness reads a folder and ignores test JSON files that start with an underscore. I just renamed the test cases that failed with this underscore.