Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validators are wrongly sorted for v.0.34 #579

Closed
andrey-kuprianov opened this issue Sep 24, 2020 · 0 comments · Fixed by #580
Closed

Validators are wrongly sorted for v.0.34 #579

andrey-kuprianov opened this issue Sep 24, 2020 · 0 comments · Fixed by #580
Assignees
Labels
bug Something isn't working
Milestone

Comments

@andrey-kuprianov
Copy link
Contributor

andrey-kuprianov commented Sep 24, 2020

There is an issue with the current sorting of validators which I've discovered because my MBT tests were failing:

In v.0.34 the validators should be first sorted by voting power (descending), then by address (ascending), but here they are sorted only by voting power (see #506). As a result, header hash validation fails.

The issue is actually also that it's not properly documented in the tendermint/spec repo and in the tendermint-rpc, the requirement is only implemented in tendermint-go.

I've already stumbled upon this before, but forgot to open the issues against the documentation repos (my bad!); will do that now. Will also fix the issue in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant