You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As of c8b97aa, and the addition of the time_iota_ms field to tendermint::block::Size, the WebSocket client cannot parse NewBlock events emitted by Tendermint because those do not include the time_iota_ms in the appropriate place.
As the time_iota_ms field is not part of Size's Protobuf counterpart, the value of this field is currently hardcoded to 1000 in the Proto->Domain conversion.
The field should probably be either removed or be added a #[serde(default = "...")] annotation so that we can parse NewBlock events again.
Steps to reproduce
Start a Tendermint node which exposes a WS server at ws://127.0.0.1:26657/websocket (eg. via ibc-rs dev-env script`)
Check out the romac/ws-inspect branch of tendermint-rs
$ cd tools/ws-inspect
$ RUST_LOG=info cargo run
Notice that we receive raw NewBlock events over the WebSocket connection but that those fail to parse because of the missing time_iota_ms field
As of c8b97aa, and the addition of the
time_iota_ms
field totendermint::block::Size
, the WebSocket client cannot parseNewBlock
events emitted by Tendermint because those do not include thetime_iota_ms
in the appropriate place.As the
time_iota_ms
field is not part ofSize
's Protobuf counterpart, the value of this field is currently hardcoded to 1000 in the Proto->Domain conversion.The field should probably be either removed or be added a
#[serde(default = "...")]
annotation so that we can parseNewBlock
events again.Steps to reproduce
ws://127.0.0.1:26657/websocket
(eg. via ibc-rsdev-env
script`)romac/ws-inspect
branch of tendermint-rs$ cd tools/ws-inspect
$ RUST_LOG=info cargo run
NewBlock
events over the WebSocket connection but that those fail to parse because of the missingtime_iota_ms
fieldThe text was updated successfully, but these errors were encountered: