Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify default value for tendermint::block::Size #931

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

romac
Copy link
Member

@romac romac commented Jul 16, 2021

Close: #930

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021

Codecov Report

Merging #931 (d4d866c) into master (1a7c160) will increase coverage by 0.0%.
The diff coverage is 83.3%.

❗ Current head d4d866c differs from pull request most recent head 08d7c95. Consider uploading reports for the commit 08d7c95 to get more accurate results
Impacted file tree graph

@@          Coverage Diff           @@
##           master    #931   +/-   ##
======================================
  Coverage    70.5%   70.6%           
======================================
  Files         203     203           
  Lines       16264   16249   -15     
======================================
+ Hits        11475   11478    +3     
+ Misses       4789    4771   -18     
Impacted Files Coverage Δ
tendermint/src/block/size.rs 33.3% <75.0%> (+20.8%) ⬆️
rpc/tests/kvstore_fixtures.rs 95.5% <100.0%> (+<0.1%) ⬆️
tendermint/src/signature.rs 58.9% <0.0%> (-1.7%) ⬇️
tendermint/src/channel.rs 37.4% <0.0%> (-0.9%) ⬇️
tendermint/src/consensus/params.rs 4.2% <0.0%> (-0.6%) ⬇️
light-client/src/types.rs 30.1% <0.0%> (-0.3%) ⬇️
tendermint/src/node.rs 65.7% <0.0%> (-0.3%) ⬇️
tendermint/src/abci/path.rs 0.0% <0.0%> (ø)
tendermint/src/channel/id.rs 25.0% <0.0%> (ø)
tendermint/src/config.rs 64.5% <0.0%> (+0.2%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7c160...08d7c95. Read the comment docs.

thanethomson added a commit that referenced this pull request Jul 16, 2021
Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson added a commit that referenced this pull request Jul 16, 2021
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Bump supported rpc-probe version of Tendermint to v0.34.9
* Regenerate kvstore fixtures using Tendermint v0.34.9
* Update kvstore tests to test #931
* Expose Size::default_time_iota_ms to access from integration test
* Implement test for #931
@thanethomson thanethomson merged commit a93a215 into master Jul 16, 2021
@thanethomson thanethomson deleted the romac/fix-new-block-parse branch July 16, 2021 13:13
romac added a commit that referenced this pull request Jul 19, 2021
* Specify default value for `tendermint::block::Size`

* Add .changelog entry

* Add test for `time_iota_ms` default (#933)

* Bump supported rpc-probe version of Tendermint to v0.34.9
* Regenerate kvstore fixtures using Tendermint v0.34.9
* Update kvstore tests to test #931
* Expose Size::default_time_iota_ms to access from integration test
* Implement test for #931

Co-authored-by: Thane Thomson <thane@informal.systems>
thanethomson added a commit that referenced this pull request Jul 19, 2021
* Propagate JSON-RPC errors through the Rust subscription

* Fix clippy warnings

* Add .changelog entry

* Update .changelog/unreleased/improvements/932-propagate-json-rpc-errors.md

Co-authored-by: Thane Thomson <thane@informal.systems>

* Update rpc/src/client/transport/router.rs

Co-authored-by: Thane Thomson <thane@informal.systems>

* Specify default value for `tendermint::block::Size` (#931)

* Specify default value for `tendermint::block::Size`

* Add .changelog entry

* Add test for `time_iota_ms` default (#933)

* Bump supported rpc-probe version of Tendermint to v0.34.9
* Regenerate kvstore fixtures using Tendermint v0.34.9
* Update kvstore tests to test #931
* Expose Size::default_time_iota_ms to access from integration test
* Implement test for #931

Co-authored-by: Thane Thomson <thane@informal.systems>

* Remove subscription id to query index in `SubscriptionRouter`

* Introduce type aliases for subscription ids and queries

* Fix dead code warnings when `websocket` feature is disabled

* Update .changelog/unreleased/bug-fixes/930-newblock-event-parse.md

Co-authored-by: Thane Thomson <thane@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpc: WebSocket client cannot parse NewBlock events
3 participants