Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Adopt forked prost crates #1005

Merged
merged 2 commits into from
Oct 6, 2021
Merged

meta: Adopt forked prost crates #1005

merged 2 commits into from
Oct 6, 2021

Conversation

xla
Copy link
Contributor

@xla xla commented Oct 6, 2021

Addresses the lack of a release of the upstream crates for a multitude
of reasons by adopting forked crates on crates.io based off of latest
master. Ideally this is a stop-gap solution until prost itself is
updated properly.

Fixes #966

Signed-off-by: xla self@xla.is

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@xla xla self-assigned this Oct 6, 2021
@xla xla changed the base branch from master to soares/chrono-timestamp October 6, 2021 01:53
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #1005 (72be665) into master (aee72bd) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1005     +/-   ##
========================================
- Coverage    72.7%   72.7%   -0.1%     
========================================
  Files         204     204             
  Lines       16624   16631      +7     
========================================
+ Hits        12100   12104      +4     
- Misses       4524    4527      +3     
Impacted Files Coverage Δ
tendermint/src/time.rs 95.7% <ø> (ø)
tendermint/src/signature.rs 56.6% <0.0%> (-4.1%) ⬇️
rpc/src/endpoint/unsubscribe.rs 0.0% <0.0%> (ø)
light-client/src/types.rs 40.8% <0.0%> (+0.3%) ⬆️
testgen/src/header.rs 80.7% <0.0%> (+0.6%) ⬆️
testgen/src/vote.rs 85.5% <0.0%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee72bd...72be665. Read the comment docs.

Addresses the lack of a release of the upstream crates for a multitude
of reasons by adopting forked crates on crates.io based off of latest
master. Ideally this is a stop-gap solution until prost itself is
updated properly.

Fixes #966

Signed-off-by: xla <self@xla.is>
Base automatically changed from soares/chrono-timestamp to master October 6, 2021 03:24
Signed-off-by: xla <self@xla.is>
Copy link
Member

@greg-szabo greg-szabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if releasing a public crate is overkill and we could've maybe gotten away with copying the code into this repo (or maybe as a sub-module). But I'm not the one to argue, let's make this happen.

@thanethomson
Copy link
Contributor

I wonder if releasing a public crate is overkill and we could've maybe gotten away with copying the code into this repo (or maybe as a sub-module). But I'm not the one to argue, let's make this happen.

Adding it as a submodule to tendermint-rs would've probably been far more work than just forking the existing project and republishing the crates under different names. It would've been far easier if we could point our crates to the official Prost repository at a specific commit, but then we wouldn't be able to publish our own crates.

Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@thanethomson thanethomson merged commit e3e4c88 into master Oct 6, 2021
@thanethomson thanethomson deleted the xla/966-forked-crates branch October 6, 2021 14:00
@thanethomson thanethomson mentioned this pull request Oct 6, 2021
5 tasks
@tony-iqlusion
Copy link
Collaborator

FYI, prost v0.9 is out: https://crates.io/crates/prost/0.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current nightly (2021-09-07) breaks build
5 participants