-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: Adopt forked prost crates #1005
Conversation
a29d146
to
554ecb7
Compare
554ecb7
to
45bdab8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1005 +/- ##
========================================
- Coverage 72.7% 72.7% -0.1%
========================================
Files 204 204
Lines 16624 16631 +7
========================================
+ Hits 12100 12104 +4
- Misses 4524 4527 +3
Continue to review full report at Codecov.
|
Addresses the lack of a release of the upstream crates for a multitude of reasons by adopting forked crates on crates.io based off of latest master. Ideally this is a stop-gap solution until prost itself is updated properly. Fixes #966 Signed-off-by: xla <self@xla.is>
45bdab8
to
86cd7c4
Compare
Signed-off-by: xla <self@xla.is>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if releasing a public crate is overkill and we could've maybe gotten away with copying the code into this repo (or maybe as a sub-module). But I'm not the one to argue, let's make this happen.
Adding it as a submodule to tendermint-rs would've probably been far more work than just forking the existing project and republishing the crates under different names. It would've been far easier if we could point our crates to the official Prost repository at a specific commit, but then we wouldn't be able to publish our own crates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing
FYI, prost v0.9 is out: https://crates.io/crates/prost/0.9.0 |
Addresses the lack of a release of the upstream crates for a multitude
of reasons by adopting forked crates on crates.io based off of latest
master. Ideally this is a stop-gap solution until prost itself is
updated properly.
Fixes #966
Signed-off-by: xla self@xla.is
Wrote tests.changelog/