Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to official Prost v0.9 #1011

Merged
merged 5 commits into from
Oct 26, 2021
Merged

Update to official Prost v0.9 #1011

merged 5 commits into from
Oct 26, 2021

Conversation

thanethomson
Copy link
Contributor

@thanethomson thanethomson commented Oct 25, 2021 •
edited
Loading

Closes #925

Supersedes #1006

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@thanethomson
Update prost dependencies to use official release
784b9bb 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Fix clippy warning/error
5705068 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Bump prost version for proto-compiler
943f66f 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Regenerate protos
158e8ba 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson marked this pull request as draft October 25, 2021 16:11
@thanethomson
Copy link
Contributor Author

thanethomson commented Oct 25, 2021 •
edited
Loading

Audit check fails due to the chrono, time and der (used by ecdsa) (der was just a warning, solved by a cargo update) dependencies. We can resolve this in separate PRs.

Related to #1007 and #1008.

@thanethomson thanethomson marked this pull request as ready for review October 25, 2021 16:28
@thanethomson thanethomson requested a review from romac October 25, 2021 16:29
@romac
Copy link
Member

romac commented Oct 26, 2021

Thanks @thanethomson! I am testing this branch now from ibc-rs, will report back once I get it to work.

@romac romac mentioned this pull request Oct 26, 2021
Merged
5 tasks
romac
romac previously approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@romac romac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, corresponding PR on ibc-rs is here: informalsystems/hermes#1501

🌷

@romac
Copy link
Member

romac commented Oct 26, 2021

Maybe this warrants an entry in the changelog, since this is a breaking change for downstream users of the library who work directly with the proto definitions?

@thanethomson
Copy link
Contributor Author

Maybe this warrants an entry in the changelog, since this is a breaking change for downstream users of the library who work directly with the proto definitions?

Yes good point! I'll add one shortly 👍

@thanethomson
Add changelog entry
2e94188 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson requested a review from romac October 26, 2021 12:24
@thanethomson thanethomson merged commit ce55f22 into master Oct 26, 2021
@thanethomson thanethomson deleted the thane/925-prost0.9 branch October 26, 2021 12:50
This was referenced Oct 26, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2021-0073: Conversion from prost_types::Timestamp to SystemTime can cause an overflow and panic
2 participants
@thanethomson @romac