Replace chrono with time 0.3 (backport to 0.23.x) #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes in tendermint: Change Time implementation to crate time. chrono has soundness issues (see RUSTSEC-2020-0159) and does not seem to be actively maintained. Ensure Time can only have values that are valid for Google protobuf Timestamp messages. Add ErrorDetail variant DateOutOfRange to report when this restriction is not met. Remove conversions between Time and chrono::DateTime, replacing them with conversions from/to time::OffsetDateTime. Conversion from time::OffsetDateTime is made fallible with a TryFrom impl. Add Time methods checked_add and checked_sub. These should be used instead of the overloaded operators that broke the operator convention by returning a Result. Changes in tendermint-pbt-gen: Change the time stragegies and helpers to produce time::OffsetDateTime values. Add strategies to generate date-time values and RFC 3339 strings in the range valid for protobuf Timestamp messages. Changes in tendermint-proto: Provide another helper in the serializers::timestamp module, one that formats into a provided fmt::Write object. Changes in tendermint-rpc: Use `OffsetDateTime` and `Date` types provided by the `time` crate in query operands instead of their `chrono` counterparts.
mzabaluev
added
enhancement
This was referenced Nov 29, 2021
Require the timestamp to be in the validity range (years 1-9999 in UTC) and the nanosecond member value to not exceed 999_999_999. Rename ErrorDetail::TimestampOverflow to TimestampNanosOutOfRange, because the old variant was not very informative (the chained TryFromIntError did not help) and we also use it for the above-range case now which is not an overflow.
Add a unit test to exercise the check.
Codecov Report
@@ Coverage Diff @@
## v0.23.x #1036 +/- ##
=========================================
Coverage ? 66.3%
=========================================
Files ? 209
Lines ? 20967
Branches ? 0
=========================================
Hits ? 13916
Misses ? 7051
Partials ? 0 Continue to review full report at Codecov.
|
- More ergonomic signature - A non-allocating implementation
Co-authored-by: Thane Thomson <thane@informal.systems>
Co-authored-by: Thane Thomson <thane@informal.systems>
thanethomson
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1030 to 0.23.x.