Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lints reported by clippy 0.1.57 #1041

Merged
merged 4 commits into from
Dec 7, 2021

Conversation

mzabaluev
Copy link
Contributor

The new lints pop up in the CI for multiple PRs.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@mzabaluev mzabaluev added the code-quality Issues relating to linting configuration and general code quality label Dec 7, 2021
@mzabaluev mzabaluev mentioned this pull request Dec 7, 2021
5 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #1041 (55d4ffd) into master (0a53b18) will increase coverage by 0.1%.
The diff coverage is 50.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1041     +/-   ##
========================================
+ Coverage    62.0%   62.1%   +0.1%     
========================================
  Files         237     237             
  Lines       21168   21140     -28     
========================================
+ Hits        13128   13132      +4     
+ Misses       8040    8008     -32     
Impacted Files Coverage Δ
rpc/src/endpoint/validators.rs 0.0% <0.0%> (ø)
rpc/src/event.rs 6.4% <0.0%> (ø)
tendermint/src/evidence.rs 21.6% <0.0%> (ø)
light-client/src/fork_detector.rs 79.0% <40.0%> (ø)
testgen/src/tester.rs 68.7% <50.0%> (ø)
rpc/src/abci/info.rs 57.1% <100.0%> (+17.1%) ⬆️
rpc/src/abci/responses.rs 50.0% <100.0%> (-5.2%) ⬇️
rpc/src/client/transport/mock.rs 88.1% <100.0%> (+0.2%) ⬆️
rpc/src/client/transport/router.rs 74.5% <100.0%> (-0.3%) ⬇️
tendermint/src/block/round.rs 83.6% <100.0%> (-0.9%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a53b18...55d4ffd. Read the comment docs.

@thanethomson thanethomson merged commit 52a603d into master Dec 7, 2021
@thanethomson thanethomson deleted the mikhail/fix-clippy-0.1.57-lints branch December 7, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Issues relating to linting configuration and general code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants