-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out verifier parts of tendermint-light-client to tendermint-light-client-verifier (Backported to v0.23) #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ht-client-verifier Rebased from master
soareschen
force-pushed
the
soares/light-client-verifier-v0.23
branch
from
January 5, 2022 21:02
704a726
to
3197709
Compare
Codecov Report
@@ Coverage Diff @@
## v0.23.x #1072 +/- ##
=========================================
+ Coverage 65.7% 67.3% +1.6%
=========================================
Files 210 212 +2
Lines 20658 20171 -487
=========================================
+ Hits 13575 13593 +18
+ Misses 7083 6578 -505
Continue to review full report at Codecov.
|
6 tasks
…light-client` (#1074) * Re-export tendermint_light_client_verifier as verifier from tendermint_light_client Signed-off-by: Thane Thomson <connect@thanethomson.com> * Remove unnecessary tendermint-light-client import Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix crate docs to reflect verifier extraction Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entry Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Merge latest changes from v0.23.x Signed-off-by: Thane Thomson <connect@thanethomson.com> * Remove redundant imports from kvstore test Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of #1071 that targets the
v0.23.x
branch. Due to the conflicts caused by moved files, the patch has the be applied in a rather convoluted way:In the first copy of tendermint-rs src:
git checkout soares/light-client-verifier
git checkout -b soares/light-client-verifier-v0.23
git reset v0.23.x
git add light-client*
git add tools/kvstore-test
git commit
git clean -fd
In the second copy of tendermint-rs src:
git checkout v0.23.x
git reset master
light-client
andlight-client-js
.3.1. I'm not sure if
git diff
would automatically do any smart diff based on a merge base. So doinggit reset
is a more guaranteed way to see the real diffs.Finally:
1.1. This cannot be automated due to moved files
git commit
on first copy.Due to the complicated steps to construct this PR. I'd hope that #1071 and this PR can be merged with minimal further changes. Otherwise for every change made I'd have to carefully cherry-pick the new commits and hope that there are no conflict raised.
.changelog/