Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: Fix clippy warnings from Rust v1.59.0 (#1097) #1103

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

thanethomson
Copy link
Contributor

Back-ports #1097

* Fix clippy warnings from Rust v1.59.0

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Workaround for flex-error-related clippy warning

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Upgrade to contracts v0.6.2 and fix clippy errors

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add changelog entry

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson changed the title Fix clippy warnings from Rust v1.59.0 (#1097) backport: Fix clippy warnings from Rust v1.59.0 (#1097) Mar 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1103 (25b123a) into v0.23.x (8a1be63) will increase coverage by 0.0%.
The diff coverage is 76.4%.

Impacted file tree graph

@@           Coverage Diff           @@
##           v0.23.x   #1103   +/-   ##
=======================================
  Coverage     67.4%   67.4%           
=======================================
  Files          212     212           
  Lines        20201   20263   +62     
=======================================
+ Hits         13619   13672   +53     
- Misses        6582    6591    +9     
Impacted Files Coverage Δ
light-client/src/evidence.rs 9.0% <0.0%> (ø)
p2p/src/error.rs 0.0% <ø> (ø)
light-client/src/components/scheduler.rs 77.7% <66.6%> (-9.4%) ⬇️
light-client/src/peer_list.rs 90.2% <83.3%> (+1.7%) ⬆️
config/src/config.rs 55.0% <100.0%> (ø)
light-client/src/light_client.rs 74.7% <100.0%> (+2.9%) ⬆️
light-client/src/state.rs 33.3% <100.0%> (ø)
tendermint/src/abci/transaction.rs 54.4% <100.0%> (ø)
tendermint/src/evidence.rs 21.6% <100.0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a1be63...25b123a. Read the comment docs.

@thanethomson thanethomson merged commit bcd57ab into v0.23.x Mar 12, 2022
@thanethomson thanethomson deleted the thane/v0.23-fix-clippy-rust-1.59 branch March 12, 2022 12:57
james-chf pushed a commit to heliaxdev/tendermint-rs that referenced this pull request Sep 30, 2022
…lsystems#1103)

* Fix clippy warnings from Rust v1.59.0

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Workaround for flex-error-related clippy warning

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Upgrade to contracts v0.6.2 and fix clippy errors

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add changelog entry

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants