p2p: Rework transport to be async #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xla
force-pushed
the
xla/692-async-transport
branch
from
64d53be to
113013a
Compare
xla
force-pushed
the
xla/692-async-transport
branch
from
113013a to
07e3ab1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1116 +/- ##
========================================
- Coverage 64.8% 64.8% -0.1%
========================================
Files 240 240
Lines 20822 20822
========================================
- Hits 13500 13493 -7
- Misses 7322 7329 +7
Continue to review full report at Codecov.
|
|
Fails because of the unmaintained serde_cbor advisory, temporarily addressed in #1119 |
Signed-off-by: xla <self@xla.is>
While it was well-intended the reality is that it's going to be impractical and hinder potential adoption trying to not give in to the sweet siren sounds of the async ecosystem. The author since has changed their stance and adopted a conviction that well tuned and guard-railed async can be workable and lead to maintainable solutions. This change-set is in preparation of bringing in peer and supervisor abstractions as described in the ADR. Signed-off-by: xla <self@xla.is>
xla
force-pushed
the
xla/692-async-transport
branch
from
07e3ab1 to
be27b6a
Compare
thanethomson
approved these changes
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it was well-intended the reality is that it's going to be
impractical and hinder potential adoption trying to not give in to the
sweet siren sounds of the async ecosystem. The author since has changed
their stance and adopted a conviction that well tuned and guard-railed
async can be workable and lead to maintainable solutions. This
change-set is in preparation of bringing in peer and supervisor
abstractions as described in the ADR.
Signed-off-by: xla self@xla.is
Individual commits are significant please review accordingly.
* [ ] Wrote tests.changelog/