first take at hooking up a node

[ebuchman]

First take at hooking it all up into a running light node!

It currently fails I think because we're computing header hashes incorrectly ...

• Referenced an issue explaining the need for the change
• Updated all relevant documentation in docs
• Updated all code comments where relevant
• Wrote tests
• Updated CHANGES.md

[tarcieri]

Perhaps it would be less ambiguous to import tendermint::hash and reference Algorithm as hash::Algorithm?

[xla]

Addressed in 712e673

@tarcieri Is it necessary to expose this param at all at this point if the enum has only one variant?

[tarcieri]

I'd say it's both more explicit and good futureproofing in the event you do ever want to support additional hash algorithms. I'll cite git as a project which didn't do this which also still hasn't managed to migrate to a new hash algorithm.

That said I doubt SHA-256 will ever be catastrophically broken.

[tarcieri]

I'd probably write this like:

Self {
    height: match height.value() {
        0 => None,
        _ => Some(height)
    }
}

Alternatively perhaps define a method on Height for this? It seems useful.

[xla]

This was a shortcut to get the integration to work. There ought to be a more explicit way to request the latest height that depending on the implicit menaing of 0.

[xla]

Addressed in 7477c9d

[ebuchman]

Opened an issue for this #118