-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Prost version to v0.11 #1171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.23.x #1171 +/- ##
=========================================
- Coverage 67.5% 67.5% -0.1%
=========================================
Files 214 214
Lines 20478 20478
=========================================
- Hits 13830 13828 -2
- Misses 6648 6650 +2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson
force-pushed
the
thane/update-prost-0.11
branch
from
August 5, 2022 02:34
f4af2f7
to
2351463
Compare
romac
approved these changes
Aug 5, 2022
thanethomson
added a commit
that referenced
this pull request
Aug 5, 2022
* Sync README with master Signed-off-by: Thane Thomson <connect@thanethomson.com> * Sync contributing guidelines with master Signed-off-by: Thane Thomson <connect@thanethomson.com> * Update README to conform to new Tendermint Core versioning approach Signed-off-by: Thane Thomson <connect@thanethomson.com> * Import Rust formatting styles from #1120 Signed-off-by: Thane Thomson <connect@thanethomson.com> * cargo +nightly fmt Signed-off-by: Thane Thomson <connect@thanethomson.com> * Apply formatting to tools Signed-off-by: Thane Thomson <connect@thanethomson.com> * Sync GitHub templates with master and remove version-specific fields Signed-off-by: Thane Thomson <connect@thanethomson.com> * Import cargo audit config from master Signed-off-by: Thane Thomson <connect@thanethomson.com> * Import ADRs from master Signed-off-by: Thane Thomson <connect@thanethomson.com> * Pin `time` to <0.3.12 to ensure we stay no-std compatible (#1174) * Pin `time` to <0.3.12 to ensure we stay no-std compatible * Apply suggestions from code review * Update proto/Cargo.toml Co-authored-by: Thane Thomson <thane@informal.systems> * Add debug! trace for the outgoing RPC request (#1173) * Update Prost version to v0.11 (#1171) * Bump Prost version to v0.11 Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entry Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add step in generated-protos-compile job to install protoc Signed-off-by: Thane Thomson <connect@thanethomson.com> * shell should be run Signed-off-by: Thane Thomson <connect@thanethomson.com> * Tell curl to follow redirects Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix protoc unzip target Signed-off-by: Thane Thomson <connect@thanethomson.com> * Install protoc to unprivileged location Signed-off-by: Thane Thomson <connect@thanethomson.com> * Regenerate protos Signed-off-by: Thane Thomson <connect@thanethomson.com> * Release v0.23.9 (#1177) * Bump version to v0.23.9 Signed-off-by: Thane Thomson <connect@thanethomson.com> * Prepare changelog release Signed-off-by: Thane Thomson <connect@thanethomson.com> * Rebuild changelog Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add note on time dependency restriction to changelog Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears as though this doesn't break anything.
I've held back from regenerating the protos using this version of Prost due to this minor issue: tokio-rs/prost#693This issue has now been fixed, so I've managed to regenerate the protos.