Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Fix deserialization of DuplicateVoteEvidence in /block_results response #1195

Merged
merged 5 commits into from
Sep 22, 2022

Conversation

romac
Copy link
Member

@romac romac commented Sep 22, 2022

Closes: #1194

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@romac romac changed the title rpc: Fix parsing of serialized duplicate vote evidence in /block_results response rpc: Fix deserialization of DuplicateVoteEvidence in /block_results response Sep 22, 2022
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romac! LGTM. The failing clippy check is on an unrelated file to this PR, I'll fix that separately in a follow-up PR.

@thanethomson thanethomson merged commit 99f4cd0 into main Sep 22, 2022
@thanethomson thanethomson deleted the romac/fix-evidence-rpc branch September 22, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpc: Cannot parse response from /block_results endpoint when it contains a DuplicateVoteEvidence
2 participants