-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abci: Change hashes' type from Bytes
to tendermint::Hash
or tendermint::AppHash
#1232
Conversation
The less cloney data accessor is better.
@@ -19,8 +18,7 @@ pub struct Info { | |||
/// The latest block for which the app has called [`Commit`](super::super::Request::Commit). | |||
pub last_block_height: block::Height, | |||
/// The latest result of [`Commit`](super::super::Request::Commit). | |||
// XXX(hdevalence): fix this, should be apphash? | |||
pub last_block_app_hash: Bytes, | |||
pub last_block_app_hash: AppHash, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mysteriously, this is serialized as an array of bytes rather than a hex string.
This PR does not change it.
Codecov Report
@@ Coverage Diff @@
## main #1232 +/- ##
=====================================
Coverage 64.2% 64.3%
=====================================
Files 244 244
Lines 21364 21373 +9
=====================================
+ Hits 13734 13746 +12
+ Misses 7630 7627 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense. And for the record, my answer to both questions in #1095 (comment) is yes.
Fixes: #1095
Both questions in #1095 (comment) are resolved with "Yes".
.changelog/