Decouple tendermint-rpc from tendermint-proto #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import tendermint::serializers instead. This removes almost all need to depend on tendermint_proto directly.
The protobuf message name is actually ProofOps, and the crypto package also defines Proof, for which we now want to have a domain type.
Corresponds to the protobuf message crypto.Proof.
Corresponds to protobuf types.TxProof
Thus removing the last direct use of tendermint_proto.
thanethomson
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1233
Replace remaining use of
prost-build-generated structs intendermint-rpcwith domain types newly defined intendermint.In
tendermint,merkle::proof::Proofwas named inconsistently with regard to protobuf, which has it ascrypto.ProofOps, yet also thecrypto.Proofmessage is defined, which we make use of now. Renamed that domain type toProofOpsto make way for the newly addedProof..changelog/