Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple tendermint-rpc from tendermint-proto #1234

Merged
merged 8 commits into from
Nov 16, 2022

Conversation

mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented Nov 16, 2022

Fixes: #1233

Replace remaining use of prost-build-generated structs in tendermint-rpc with domain types newly defined in tendermint.

In tendermint, merkle::proof::Proof was named inconsistently with regard to protobuf, which has it as crypto.ProofOps, yet also the crypto.Proof message is defined, which we make use of now. Renamed that domain type to ProofOps to make way for the newly added Proof.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Import tendermint::serializers instead. This removes almost all
need to depend on tendermint_proto directly.
The protobuf message name is actually ProofOps, and
the crypto package also defines Proof, for which we now
want to have a domain type.
Corresponds to the protobuf message crypto.Proof.
Corresponds to protobuf types.TxProof
Thus removing the last direct use of tendermint_proto.
@mzabaluev mzabaluev marked this pull request as ready for review November 16, 2022 19:48
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @mzabaluev!

@thanethomson thanethomson merged commit c5f76fb into main Nov 16, 2022
@thanethomson thanethomson deleted the mikhail/decouple-rpc-from-proto branch November 16, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple tendermint-rpc from tendermint-proto
2 participants