Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.29.1 release of tendermint #1273

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

hdevalence
Copy link
Collaborator

This commit only bumps the patch version of the tendermint crate; since it's compatible and will be auto-selected, it didn't seem important to bump all of the versions of all of the other crates, or bump their dependency specifications.

@thanethomson
Copy link
Contributor

The trouble with only bumping the one crate's patch version is, say you need to make a patch update to a different crate at a later stage (e.g. the tendermint-abci crate) after having pushed the v0.29.1 tag to cut the release - what tag do you push to the Git repo to trigger the next release? Then you'll already have used v0.29.1.

This is partly why we version all crates in lockstep.

The only other alternative is to delete the v0.29.1 tag and push it again at a later stage if you bump a different crate's patch version to v0.29.1 and want to trigger its release. We haven't tested this approach, however, with our current release script.

@hdevalence
Copy link
Collaborator Author

Sounds reasonable, I replaced all of the 0.29.0 versions by 0.29.1 instead.

@hdevalence hdevalence marked this pull request as ready for review February 25, 2023 00:28
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦾

Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to merge and then tag whenever you're ready.

@hdevalence hdevalence merged commit 6379c82 into informalsystems:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants