Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse and fetch proto dependencies from buf.lock in the repository source #1293

Merged
merged 5 commits into from
Apr 14, 2023

Conversation

mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented Apr 5, 2023

Resolves #1289

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

The checkouts could come from either tendermint or cometbft
repository, and some forks might conceivably want to use both.
In case the buf.lock file is present, fetch the dependencies by
shelling out to the `buf export` command rather than relying on
the files included in third_party.
Use the modified tendermint-proto-compiler, fetching from
the official release tags in the CometBFT repo.
@mzabaluev mzabaluev marked this pull request as ready for review April 6, 2023 11:28
@mzabaluev mzabaluev changed the title Parse and fetch proto dependencies from buf.lock Parse and fetch proto dependencies from buf.lock in the repository source Apr 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1293 (16786cc) into main (60e10ab) will decrease coverage by 0.1%.
The diff coverage is 76.4%.

❗ Current head 16786cc differs from pull request most recent head ff92c4d. Consider uploading reports for the commit ff92c4d to get more accurate results

@@           Coverage Diff           @@
##            main   #1293     +/-   ##
=======================================
- Coverage   64.1%   64.0%   -0.1%     
=======================================
  Files        271     271             
  Lines      24291   24322     +31     
=======================================
+ Hits       15584   15590      +6     
- Misses      8707    8732     +25     
Impacted Files Coverage Δ
light-client-verifier/src/verifier.rs 93.2% <ø> (ø)
tendermint/src/signature.rs 44.6% <33.3%> (-0.5%) ⬇️
tendermint/src/public_key.rs 76.3% <50.0%> (+6.4%) ⬆️
tendermint/src/account.rs 82.5% <100.0%> (ø)
tendermint/src/crypto/default/signature.rs 92.0% <100.0%> (ø)
tendermint/src/test.rs 100.0% <100.0%> (ø)
tendermint/src/vote.rs 78.3% <100.0%> (ø)
tendermint/tests/alt_crypto.rs 92.5% <100.0%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@mzabaluev mzabaluev merged commit 2067103 into main Apr 14, 2023
@mzabaluev mzabaluev deleted the mikhail/use-buf-for-proto-deps branch April 14, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not generate tendermint-proto from source with buf dependencies
3 participants