Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC: Provide earliest block information from /status #1321

Merged
merged 2 commits into from
Jun 14, 2023
Merged

RPC: Provide earliest block information from /status #1321

merged 2 commits into from
Jun 14, 2023

Conversation

mdyring
Copy link
Contributor

@mdyring mdyring commented Jun 14, 2023 •
edited by mzabaluev
Loading

This is a trivial addition of missing /status RPC fields, specifically the "earliest block" information.

This information is useful and tells us the range of blocks that can be queried from a node. To be used for a Cosmos block crawler/indexer project.

I deemed the change so minor as to not warrant a changelog entry.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

mzabaluev
mzabaluev approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Looks good.

rpc/src/endpoint/status.rs Show resolved Hide resolved
@mzabaluev mzabaluev merged commit dba8242 into informalsystems:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzabaluev mzabaluev mzabaluev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdyring @mzabaluev