Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: prepare v0.33.1 #1345

Merged
merged 3 commits into from
Aug 31, 2023
Merged

release: prepare v0.33.1 #1345

merged 3 commits into from
Aug 31, 2023

Conversation

erwanor
Copy link
Collaborator

@erwanor erwanor commented Aug 29, 2023

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Merging #1345 (43bf87a) into main (cc04d6b) will increase coverage by 0.0%.
The diff coverage is 50.0%.

❗ Current head 43bf87a differs from pull request most recent head f5470fd. Consider uploading reports for the commit f5470fd to get more accurate results

@@          Coverage Diff          @@
##            main   #1345   +/-   ##
=====================================
  Coverage   59.5%   59.5%           
=====================================
  Files        272     272           
  Lines      26981   26974    -7     
=====================================
  Hits       16068   16068           
+ Misses     10913   10906    -7     
Files Changed Coverage Δ
p2p/src/secret_connection.rs 85.5% <50.0%> (-0.3%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erwanor erwanor marked this pull request as ready for review August 30, 2023 04:16
@erwanor
Copy link
Collaborator Author

erwanor commented Aug 30, 2023

My suggestion is to ignore the webpki cargo audit warning, release 0.33.1 and later release a new major version if it's necessary. At a glance it seems like we would need to work with some upstreams like hyper-proxy:

webpki v0.21.4
├── hyper-proxy v0.9.1
│   └── tendermint-rpc v0.33.1 (/Users/user/tendermint-rs/rpc)
│       ├── tendermint-light-client v0.33.1 (/Users/user/tendermint-rs/light-client)
│       │   ├── tendermint-light-client-cli v0.33.1 (/Users/user/tendermint-rs/light-client-cli)
│       │   └── tendermint-light-client-detector v0.33.1 (/Users/user/tendermint-rs/light-client-detector)
│       │       └── tendermint-light-client-cli v0.33.1 (/Users/user/tendermint-rs/light-client-cli)
│       ├── tendermint-light-client-cli v0.33.1 (/Users/user/tendermint-rs/light-client-cli)
│       └── tendermint-light-client-detector v0.33.1 (/Users/user/tendermint-rs/light-client-detector) (*)
├── hyper-rustls v0.22.1
│   ├── hyper-proxy v0.9.1 (*)
│   └── tendermint-rpc v0.33.1 (/Users/user/tendermint-rs/rpc) (*)
├── rustls v0.19.1
│   ├── hyper-rustls v0.22.1 (*)
│   ├── rustls-native-certs v0.5.0
│   │   ├── hyper-proxy v0.9.1 (*)
│   │   └── hyper-rustls v0.22.1 (*)
│   └── tokio-rustls v0.22.0
│       ├── hyper-proxy v0.9.1 (*)
│       └── hyper-rustls v0.22.1 (*)
├── tokio-rustls v0.22.0 (*)
└── webpki-roots v0.21.1
    └── hyper-rustls v0.22.1 (*)

This is tracked in #1342.

@tony-iqlusion
Copy link
Collaborator

hyper-proxy needs to migrate from webpki to rustls-webpki (a maintained fork of webpki)

Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a release.

It does not look like hyper-proxy is going to be updated any time soon.
Let's see what the hyper/tonic upstream will do to remedy this.

We can always make another patch release unless a dependency update forces us into 0.34.

@erwanor erwanor merged commit a73362d into main Aug 31, 2023
23 of 25 checks passed
@erwanor erwanor deleted the release/v0.33.1 branch August 31, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants