Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo warning by explicitly specifying a resolver for the workspace #1363

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

romac
Copy link
Member

@romac romac commented Sep 29, 2023

Fix the following cargo warning when building the workspace:

warning: some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@codecov-commenter
Copy link

Codecov Report

Merging #1363 (9943ff6) into main (93877da) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head 9943ff6 differs from pull request most recent head ecec5f2. Consider uploading reports for the commit ecec5f2 to get more accurate results

@@          Coverage Diff          @@
##            main   #1363   +/-   ##
=====================================
  Coverage   61.1%   61.1%           
=====================================
  Files        274     274           
  Lines      26794   26794           
=====================================
  Hits       16386   16386           
  Misses     10408   10408           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I've been constantly annoyed about this myself.

@mzabaluev mzabaluev merged commit 33b3c10 into main Sep 29, 2023
25 checks passed
@mzabaluev mzabaluev deleted the romac/resolver-2 branch September 29, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants