Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: expose http::Builder, websocket::Builder under client #1378

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented Nov 9, 2023

Re-export client::transport::{http, websocket} (guarded by appropriate feature gates) publicly under the client module.
This exposes the Builder types defined in each of the modules as public API, with properly built documentation.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Re-export client::transport::{http, websocket} (guarded by appropriate
feature gates) publicly under the client module.
This is to expose the Builder types defined in each of the modules
as public API, with properly built documentation.
@mzabaluev mzabaluev added documentation Improvements or additions to documentation rpc labels Nov 9, 2023
@mzabaluev mzabaluev changed the title rpc: expose http, websocket under client rpc: expose http::Builder, websocket::Builder under client Nov 9, 2023
@mzabaluev mzabaluev marked this pull request as ready for review November 9, 2023 14:48
@codecov-commenter
Copy link

Codecov Report

Merging #1378 (fdf8f64) into main (37822e5) will decrease coverage by 0.7%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head fdf8f64 differs from pull request most recent head 79ee9d0. Consider uploading reports for the commit 79ee9d0 to get more accurate results

@@           Coverage Diff           @@
##            main   #1378     +/-   ##
=======================================
- Coverage   59.7%   59.0%   -0.7%     
=======================================
  Files        275     275             
  Lines      27597   27930    +333     
=======================================
+ Hits       16485   16491      +6     
- Misses     11112   11439    +327     
Files Coverage Δ
light-client-verifier/src/errors.rs 3.3% <ø> (ø)
rpc/src/client.rs 4.5% <ø> (ø)

... and 4 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@mzabaluev mzabaluev merged commit 194d81e into main Nov 10, 2023
23 checks passed
@mzabaluev mzabaluev deleted the mikhail/expose-rpc-client-builders branch November 10, 2023 10:42
mzabaluev added a commit that referenced this pull request Feb 21, 2024
Re-export client::transport::{http, websocket} (guarded by appropriate
feature gates) publicly under the client module.
This exposes the Builder types defined in each of the modules
as public API, with properly built documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation rpc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants